Feat/autoscaling confirmation #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulrayal
requested review from
yogesh-badke,
dhavalmehta07 and
akshaypatidar1999
added 2 commits
April 14, 2023 14:23
internal/command/commands/service.go
Outdated
| @@ -471,6 +481,30 @@ func (s *Service) askForConsent(envName *string) int { | |||
| return 0 | |||
| } | |||
|
|
|||
| func (s *Service) askForScalingConset(serviceName *string, envName *string, data map[string]interface{}) int { | |||
There was a problem hiding this comment.
spelling mistake
| return 1 | ||
| } | ||
| for _, component := range componentListResponse.Response { | ||
| consentMessage := fmt.Sprintf("\nYou have enabled reactive scaling for %s, this means %s will no longer be scaled using Scaler post this operation. Do you wish to continue? [Y/n]:", component, component) |
There was a problem hiding this comment.
This message is used twice, move this to constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added confirmation for autoscaling and --file for operate component