Fix/service set update

cmd/deploy/service-set.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"os"
 
+	"github.com/dream11/odin/internal/ui"
 	"github.com/dream11/odin/pkg/config"
 	serviceDto "github.com/dream11/odin/proto/gen/go/dream11/od/dto/v1"
 	serviceProto "github.com/dream11/odin/proto/gen/go/dream11/od/service/v1"
@@ -61,8 +62,56 @@ func executeDeployServiceSet(cmd *cobra.Command) {
 		deployServiceSetRequest.Name = serviceSetName
 	}
 
+	conflictingServicesRequest := &serviceProto.GetConflictingServicesRequest{
+		EnvName: env,
+		Name:    deployServiceSetRequest.Name,
+	}
+
+	services, errs := serviceClient.GetConflictingServices(&ctx, conflictingServicesRequest)
+	if errs != nil {
+		log.Fatal("Failed to list services with conflicting versions. ", errs)
+		return
+	}
+	var serviceNames []string
+	for _, service := range services.Services {
+
+		allowedInputsSlice := []string{"y", "n"}
+		allowedInputs := make(map[string]struct{}, len(allowedInputsSlice))
+		for _, input := range allowedInputsSlice {
+			allowedInputs[input] = struct{}{}
+		}
+		message := "Service already deployed with different version.Do you want to deploy service " + service.Name + " ? (y/n)"
+		inputHandler := ui.Input{}
+		val, err := inputHandler.AskWithConstraints(message, allowedInputs)
+
+		if err != nil {
+			log.Fatal(err.Error())
+		}
+
+		if val != "y" {
+			log.Info("Skipping service ", service.Name, " from deploy")
+			serviceNames = append(serviceNames, service.Name)
+		}
+		// Remove services from deployServiceSetRequest
+		var updatedServices []*serviceProto.ServiceIdentifier
+		for _, svc := range deployServiceSetRequest.Services {
+			shouldRemove := false
+			for _, name := range serviceNames {
+				if svc.ServiceName == name {
+					shouldRemove = true
+					break
+				}
+			}
+			if !shouldRemove {
+				updatedServices = append(updatedServices, svc)
+			}
+		}
+		deployServiceSetRequest.Services = updatedServices
+
+	}
+
 	err := serviceClient.DeployServiceSet(&ctx, &deployServiceSetRequest)
 	if err != nil {
-		log.Fatal("Failed to deploy service ", err)
+		log.Fatal("Failed to deploy service set. ", err)
 	}
 }

internal/service/service.go

@@ -1,6 +1,7 @@
 package service
 
 import (
+	"bytes"
 	"context"
 	"errors"
 	"fmt"
@@ -11,6 +12,7 @@ import (
 	"github.com/dream11/odin/pkg/util"
 	serviceDto "github.com/dream11/odin/proto/gen/go/dream11/od/dto/v1"
 	serviceProto "github.com/dream11/odin/proto/gen/go/dream11/od/service/v1"
+	"github.com/olekukonko/tablewriter"
 	log "github.com/sirupsen/logrus"
 )
 
@@ -49,7 +51,7 @@ func (e *Service) DeployService(ctx *context.Context, request *serviceProto.Depl
 		}
 
 		if response != nil {
-			message = util.GenerateResponseMessage(response.GetServiceResponse())
+			message = util.GenerateResponseMessage(response.ServiceResponse)
 			spinnerInstance.Prefix = fmt.Sprintf(" %s  ", message)
 			spinnerInstance.Start()
 		}
@@ -63,6 +65,7 @@ func (e *Service) DeployService(ctx *context.Context, request *serviceProto.Depl
 func (e *Service) DeployServiceSet(ctx *context.Context, request *serviceProto.DeployServiceSetRequest) error {
 	conn, requestCtx, err := grpcClient(ctx)
 	if err != nil {
+		log.Errorf("TraceID: %s", (*requestCtx).Value(constant.TraceIDKey))
 		return err
 	}
 	client := serviceProto.NewServiceServiceClient(conn)
@@ -81,7 +84,7 @@ func (e *Service) DeployServiceSet(ctx *context.Context, request *serviceProto.D
 	var message string
 	for {
 		response, err := stream.Recv()
-		spinnerInstance.Stop()
+
 		if err != nil {
 			if errors.Is(err, context.Canceled) || err == io.EOF {
 				break
@@ -91,16 +94,34 @@ func (e *Service) DeployServiceSet(ctx *context.Context, request *serviceProto.D
 		}
 
 		if response != nil {
-			message = ""
+			spinnerInstance.Stop()
+			var buf bytes.Buffer
+			table := tablewriter.NewWriter(&buf)
+			table.SetHeader([]string{"Service Name", "Service Version", "Service Tags", "Service Action", "Service Status", "Error"})
 			for _, serviceResponse := range response.GetServices() {
-				message += util.GenerateResponseMessage(serviceResponse.GetServiceResponse())
+				var errorMessage string
+				if serviceResponse.ServiceResponse.ServiceStatus.ServiceStatus == "FAILED" {
+					traceID := (*requestCtx).Value(constant.TraceIDKey)
+					errorMessage += fmt.Sprintf("[%s] TraceID: %s \n", serviceResponse.ServiceResponse.ServiceStatus.Error, traceID)
+				}
+				row := []string{
+					serviceResponse.ServiceIdentifier.ServiceName,
+					serviceResponse.ServiceIdentifier.ServiceVersion,
+					serviceResponse.ServiceIdentifier.Tags,
+					serviceResponse.ServiceResponse.ServiceStatus.ServiceAction,
+					serviceResponse.ServiceResponse.ServiceStatus.ServiceStatus,
+					errorMessage,
+				}
+				table.Append(row)
 			}
+
+			table.Render()
+			message = buf.String()
 			spinnerInstance.Prefix = fmt.Sprintf(" %s  ", message)
 			spinnerInstance.Start()
 		}
 	}
-
-	log.Info(message)
+	fmt.Println(message)
 	return err
 }
 
@@ -301,8 +322,9 @@ func (e *Service) ConvertToDeployServiceSetRequest(serviceSet *serviceDto.Servic
 	var services []*serviceProto.ServiceIdentifier
 	for _, service := range serviceSet.Services {
 		services = append(services, &serviceProto.ServiceIdentifier{
-			ServiceName:    service.ServiceName,
-			ServiceVersion: service.ServiceVersion,
+			ServiceName:    service.Name,
+			ServiceVersion: service.Version,
+			Tags:           service.Tags,
 		})
 	}
 
@@ -328,3 +350,17 @@ func (e *Service) DescribeService(ctx *context.Context, request *serviceProto.De
 
 	return response, nil
 }
+
+// GetConflictingServices deploys service
+func (e *Service) GetConflictingServices(ctx *context.Context, request *serviceProto.GetConflictingServicesRequest) (*serviceProto.GetConflictingServicesResponse, error) {
+	conn, requestCtx, err := grpcClient(ctx)
+	if err != nil {
+		return &serviceProto.GetConflictingServicesResponse{}, err
+	}
+	client := serviceProto.NewServiceServiceClient(conn)
+	response, err := client.GetConflictingServices(*requestCtx, request)
+	if err != nil {
+		log.Errorf("TraceID: %s", (*requestCtx).Value(constant.TraceIDKey))
+	}
+	return response, err
+}

pkg/util/util.go

@@ -10,6 +10,7 @@ import (
 
 	v1 "github.com/dream11/odin/proto/gen/go/dream11/od/service/v1"
 	"github.com/google/uuid"
+	"github.com/olekukonko/tablewriter"
 )
 
 // SplitProviderAccount splits string into list of cloud provider accounts
@@ -35,6 +36,27 @@ func GenerateResponseMessage(response *v1.ServiceResponse) string {
 	return message
 }
 
+// GenerateServiceSetResponseMessage generate response message from ServiceSetResponse
+func GenerateServiceSetResponseMessage(response *v1.DeployServiceSetServiceResponse) string {
+
+	message := fmt.Sprintf("\n Service %s %s %s %s", response.ServiceIdentifier.ServiceName, response.ServiceIdentifier.ServiceVersion, response.ServiceResponse.ServiceStatus.ServiceAction, response.ServiceResponse.ServiceStatus)
+	var tableData [][]string
+	row := []string{
+		response.ServiceIdentifier.ServiceName,
+		response.ServiceIdentifier.ServiceVersion,
+		response.ServiceResponse.ServiceStatus.ServiceAction,
+		response.ServiceResponse.ServiceStatus.ServiceStatus,
+	}
+	tableData = append(tableData, row)
+
+	table := tablewriter.NewWriter(os.Stdout)
+	table.SetHeader([]string{"Service Name", "Service Version", "Service Action", "Service Status", "Error"})
+	table.AppendBulk(tableData)
+	table.Render()
+	return message
+
+}
+
 // FormatToHumanReadableDuration takes a date-time string representing the last deployment time, and returns a human-readable string representing the duration since the last deployment
 func FormatToHumanReadableDuration(inputDateTime string) string {
 	// Check if the input is a Unix timestamp prefixed by "seconds:"

proto/dream11/od/dto/v1/service.proto

@@ -23,8 +23,9 @@ message ServiceDefinition {
 }
 
 message ServiceIdentifier {
-  string service_name = 1;
-  string service_version = 2;
+  string name = 1;
+  string version = 2;
+  string tags = 3;
 }
 
 message ServiceSet {

proto/dream11/od/service/v1/service.proto

@@ -16,6 +16,7 @@ service ServiceService {
   rpc ListService(ListServiceRequest) returns (ListServiceResponse) {}
   rpc DescribeService(DescribeServiceRequest) returns (DescribeServiceResponse) {}
   rpc OperateComponentDiff(OperateComponentDiffRequest) returns (OperateComponentDiffResponse) {}
+  rpc GetConflictingServices(GetConflictingServicesRequest) returns (GetConflictingServicesResponse) {}
 }
 
 message DeployServiceRequest {
@@ -143,3 +144,12 @@ message OperateComponentDiffResponse {
   google.protobuf.Struct old_values = 1;
   google.protobuf.Struct new_values = 2;
 }
+message GetConflictingServicesRequest {
+  string env_name = 1;
+  string name = 2;
+  repeated ServiceIdentifier services = 3;
+}
+
+message GetConflictingServicesResponse {
+  repeated dto.v1.ServiceMetadata services = 1;
+}