Gymnasium v1.0.0 support #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed API changes - Added `_gymnasium_version_gt_0_29_1` global variable to track gymnasium version. - Updated `monitor` function to handle new `RecordVideo` API introduced in gymnasium v0.29.1+. - Maintained compatibility with gym versions <0.26.0 by conditionally setting `path` and `recorder`. - Patched appropriate video recorder based on the detected version of gym or gymnasium. - Ensured proper cleanup and logging of video recordings. This commit ensures that the wandb integration works seamlessly with both older and newer versions of gym and gymnasium libraries.
…gymnasium - Changed from directly importing RecordVideo to using `getattr` to dynamically fetch the `RecordVideo` wrapper. - Ensured compatibility with gymnasium v0.29.1+ by modifying how the `RecordVideo` class is accessed. This update ensures a more flexible and error-free way of accessing the `RecordVideo` wrapper for newer gymnasium versions.
…gym <0.26 - Added support for gymnasium v1.0.0 by checking for the new `RecordVideo` wrapper. - Maintained backward compatibility with older versions of gym and gymnasium. - Implemented conditional logic to handle the breaking changes in gym 0.26.0. - Updated `_gymnasium_version_lt_1_0_0` to check for gymnasium versions less than 1.0.0. - Refactored the `close` function to include conditional logic for both new and old APIs.
…ersions - Adjusted the `_gymnasium_version_lt_1_0_0` check to compare against `1.0.0a1` to include alpha versions.
- Deleted the duplicate `vcr = wandb.util.get_module` line before the global variable declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
monitor_gymwandb/wandb#7047This PR updates the
monitor_gymintegration to support the upcoming Gymnasiumv1.0.0release. The key changes include:v1.0.0.v1.0.0and later versions.Testing
How was this PR tested?
I ran the "Stable Baselines 3 - Track Experiments with Weights and Biases" example Jupyter notebook using: