Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix locale to en-US #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

don-vip
Copy link

@don-vip don-vip commented Jul 29, 2024

So that we can perform the comparison on non-english systems

@don-vip don-vip marked this pull request as draft July 29, 2024 20:10
@don-vip don-vip force-pushed the fix-version-and-locale branch from 390d037 to db38285 Compare July 29, 2024 20:29
@don-vip don-vip marked this pull request as ready for review July 29, 2024 20:30
@don-vip don-vip force-pushed the fix-version-and-locale branch from db38285 to 2ffaee5 Compare July 29, 2024 20:30
@don-vip don-vip changed the title update xmpcore version, fix locale to en-US fix locale to en-US Jul 29, 2024
@don-vip don-vip marked this pull request as draft July 29, 2024 20:34
@don-vip don-vip marked this pull request as ready for review July 29, 2024 20:47
@don-vip
Copy link
Author

don-vip commented Jul 29, 2024

It allows to not be dependent of system language, but I can't find a way to force the default .NET timezone to Australia/Sydney, like what is done on Java side.

So right now it's simply not possible to get a simple diff if the system timezone is not set to Sydney. It makes non-regression testing very hard.

@don-vip don-vip force-pushed the fix-version-and-locale branch from 2ffaee5 to 2bdb6b8 Compare July 29, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant