USDC deposits do not work: wrong close_account call and UnboundLocalError: local variable 'ata_pubkey' referenced before assignment

[akalmykov]

Comparing TS SDK deposit with Python SDK deposits reveals a problem with close_account call when trying to deposit something different from WSOL, e.g. USDC deposit.

First, this line uses ata_pubkey that might not be initialized:

driftpy/src/driftpy/drift_client.py

Line 1024 in 961676c

account=ata_pubkey,

which results in:

UnboundLocalError: local variable 'ata_pubkey' referenced before assignment

The reason is that only get initilized here

driftpy/src/driftpy/drift_client.py

Line 986 in 961676c

ixs, ata_pubkey = await self.get_wrapped_sol_account_creation_ixs(amount)

Instead of ata_pubkey , user_token_account should be used as it happens in TS SDK.

Second, similar to TS sdk we need to check create_WSOL_token_account before adding close instruction to the transaction:

        if create_WSOL_token_account:
            close_account_params = CloseAccountParams(
                program_id=TOKEN_PROGRAM_ID,
                account=user_token_account,
                dest=signer_authority,
                owner=signer_authority,
            )
            close_account_ix = close_account(close_account_params)
            instructions.append(close_account_ix)

[SinaKhalili]

Looks good, thanks for catching this