bulk account loader #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
commented
Nov 21, 2023
| ) | ||
| rpc_requests.append(rpc_request) | ||
|
|
||
| resp = await self.connection._provider.session.post( |
crispheaney
commented
Nov 21, 2023
| @abstractmethod | ||
| def unsubscribe(self): | ||
| pass | ||
|
|
||
| @abstractmethod | ||
| async def get_user_account_and_slot(self) -> Optional[DataAndSlot[User]]: |
There was a problem hiding this comment.
should i make these not async?
0xbigz
reviewed
Nov 22, 2023
| @@ -72,7 +72,7 @@ def __init__( | |||
| self.subaccounts = [0] | |||
|
|
|||
| if account_subscriber is None: | |||
| account_subscriber = CachedDriftClientAccountSubscriber(self.program) | |||
| account_subscriber = WebsocketDriftClientAccountSubscriber(self.program) | |||
There was a problem hiding this comment.
this is default to websocket? is that same as typescript
0xbigz
reviewed
Nov 22, 2023
| if "1K" in str(oracle_source): | ||
| scale = 1e3 | ||
| elif "1M" in str(oracle_source): | ||
| scale = 1e6 |
There was a problem hiding this comment.
todo: add support for the stable type
There was a problem hiding this comment.
yeah and there is an issue with Pyth versus PYTH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.