-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyth lazer integration #1361
pyth lazer integration #1361
Conversation
"instruction index must be greater than 0 to include the sig verify ix" | ||
)?; | ||
|
||
let verified = pyth_lazer_sdk::verify_message( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this only think we use from pyth_lazer_sdk? can we just pull this into our own package so we dont needa take a dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd like to leave it for now becuase they said it's still in beta and that their code/api can change. once it's finalized i agree
}; | ||
pyth_lazer_oracle.price = price.0.get(); | ||
pyth_lazer_oracle.posted_slot = Clock::get()?.slot; | ||
pyth_lazer_oracle.publish_time = next_timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the ts from pythnet? we probably want the ts from solana and pythnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it's the ts from pythnet. you want to store the solana clock time on the account as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess we dont do it for the other oracles, if we think we'd ever use it, it might make sense
pyth_lazer_oracle.price = price.0.get(); | ||
pyth_lazer_oracle.posted_slot = Clock::get()?.slot; | ||
pyth_lazer_oracle.publish_time = next_timestamp; | ||
pyth_lazer_oracle.conf = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should chat about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can chat whenever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 confidence will probably mess w things, you should ask z how to handle it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confidence being 0 and not having twap is mostly just because it's not available in pyth lazer yet in general. but pyth says they will be adding it in going forward in which case i'll change this
No description provided.