Try catch around price calculation #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reverted the price calculation back to the original with a try catch around the BN casting. This seems safest w.r.t. making sure the math is correct
The only time an overflow occurs is in the case of a stink offer where the quantity is in between 2^53 and 2^64. I think it should be reasonable to avoid anything in this range, but let me know if you disagree.
I'm also adding test scripts for a couple different mainnet markets to assure that the resulting bid-ask spread is reasonable.
Sorry about any issues that this may have caused you system - hopefully this unambiguously solves the issues.