Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasting mode for instructors #6

Closed

Conversation

pbanaszkiewicz
Copy link

Hi @drio

(refs #3)

I worked on broadcasting mode a little bit.
Thanks to PeerJS "one way calls" it was possible to make this broadcasting mode. However, I'm very unhappy with how events are propagated through Pitt and I really want to drop socket.io and to switch to WAMP.

I wrote a blogpost about the changes.

There are some bugs in the code, unfortunately. And lots and lots of console.log debugging debris.

Some one the bugs include:

  • for the broadcasting mode to work instructor have to "show up" last - ie. after all their students show up. That's because the code for instructor emits an event that's crucial for broadcasting when the instructor loads their page.
  • after broadcasting session is over, students have to reload their pages in order to receive a new broadcast. Otherwise there's and error occurring in PeerJS lib. I think it's connected to some HTML tag missing from the DOM, but I didn't investigate further.

Moved files from `./client` to `./peerinstruction/public`.

Reworked `server/load.js` and `server/logic.js` to work as application
starters.

Next to do: change views to use Jade engine.
I started preparing JS code for broadcasting
@drio
Copy link
Owner

drio commented Jun 14, 2014

Comments on this in #1.

@drio drio mentioned this pull request Jun 14, 2014
@drio
Copy link
Owner

drio commented Jun 17, 2014

Closing since all this will be reimplemented on the WAMP pr.

@drio drio closed this Jun 17, 2014
@pbanaszkiewicz pbanaszkiewicz deleted the issue/3_broadcast_mode branch June 23, 2014 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants