Merge pull request #160 from drmohundro/swiftlint-for-package.swift

Add swiftlint for Package.swift

.swiftlint.yml

@@ -1,6 +1,7 @@
 included:
   - Source
   - Tests
+  - ./Package.swift
 opt_in_rules:
   - attributes
   - closure_end_indentation

Package.swift

@@ -1,22 +1,48 @@
 // swift-tools-version:4.0
+
+//
+//  SWXMLHash.swift
+//  SWXMLHash
+//
+//  Copyright (c) 2014 David Mohundro
+//
+//  Permission is hereby granted, free of charge, to any person obtaining a copy
+//  of this software and associated documentation files (the "Software"), to deal
+//  in the Software without restriction, including without limitation the rights
+//  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+//  copies of the Software, and to permit persons to whom the Software is
+//  furnished to do so, subject to the following conditions:
+//
+//  The above copyright notice and this permission notice shall be included in
+//  all copies or substantial portions of the Software.
+//
+//  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+//  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+//  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+//  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+//  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+//  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+//  THE SOFTWARE.
+//
+
 import PackageDescription
 
 let package = Package(
-  name: "SWXMLHash",
-  products: [
-  	.library(
-  	  name: "SWXMLHash",
-  	  targets: ["SWXMLHash"]
-  	)
-  ],
-  targets: [
-    .target(
-  	  name: "SWXMLHash",
-  	  path: "Source"
-  	),
-    .testTarget(
-      name: "SWXMLHashTests",
-      dependencies: ["SWXMLHash"]
-    )
-  ]
+    name: "SWXMLHash",
+    products: [
+        .library(
+            name: "SWXMLHash",
+            targets: ["SWXMLHash"]
+        )
+    ],
+    targets: [
+        .target(
+            name: "SWXMLHash",
+            path: "Source"
+        ),
+        .testTarget(
+            name: "SWXMLHashTests",
+            dependencies: ["SWXMLHash"]
+        )
+    ]
 )

Rakefile

@@ -5,7 +5,7 @@ end
 desc 'Clean, build and test SWXMLHash'
 task :test do |_t|
   # xctool_build_cmd = './scripts/build.sh'
-  xcode_build_cmd = 'xcodebuild -workspace SWXMLHash.xcworkspace -scheme "SWXMLHash iOS" -destination "OS=11.0,name=iPhone 7" clean build test -sdk iphonesimulator | xcpretty'
+  xcode_build_cmd = 'xcodebuild -workspace SWXMLHash.xcworkspace -scheme "SWXMLHash iOS" -destination "OS=11.0.1,name=iPhone 7" clean build test -sdk iphonesimulator'
 
   #if system('which xctool')
     #run xctool_build_cmd

Source/SWXMLHash.swift

@@ -209,7 +209,7 @@ extension XMLParserDelegate {
                 didStartElement elementName: String,
                 namespaceURI: String?,
                 qualifiedName qName: String?,
-                attributes attributeDict: [String : String]) { }
+                attributes attributeDict: [String: String]) { }
 
     func parser(_ parser: Foundation.XMLParser,
                 didEndElement elementName: String,
@@ -641,7 +641,7 @@ public enum XMLIndexer {
                     return .list(match)
                 }
             }
-            fallthrough
+            return .xmlError(IndexingError.key(key: key))
         default:
             throw IndexingError.key(key: key)
         }
@@ -684,7 +684,7 @@ public enum XMLIndexer {
             if index == 0 {
                 return .element(elem)
             }
-            fallthrough
+            return .xmlError(IndexingError.index(idx: index))
         default:
             return .xmlError(IndexingError.index(idx: index))
         }