Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: GitHub action and swiftlint cleanup #231

Merged
merged 6 commits into from
Jan 22, 2020
Merged

Conversation

drmohundro
Copy link
Owner

Includes:

  • bump in github swiftlint action version
  • run github actions on push and pull_request
  • prefer implicit return fix for swiftlint

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is 70.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   74.98%   74.98%           
=======================================
  Files          13       13           
  Lines        1851     1851           
=======================================
  Hits         1388     1388           
  Misses        463      463
Impacted Files Coverage Δ
Tests/SWXMLHashTests/SWXMLHashConfigTests.swift 63.63% <0%> (ø) ⬆️
...ests/SWXMLHashTests/LazyTypesConversionTests.swift 71.87% <0%> (ø) ⬆️
Tests/SWXMLHashTests/LazyXMLParsingTests.swift 76.92% <0%> (ø) ⬆️
...SWXMLHashTests/MixedTextWithXMLElementsTests.swift 60% <0%> (ø) ⬆️
.../TypeConversionArrayOfNonPrimitiveTypesTests.swift 70.22% <0%> (ø) ⬆️
...ts/SWXMLHashTests/LazyWhiteSpaceParsingTests.swift 76.19% <0%> (ø) ⬆️
Tests/SWXMLHashTests/XMLParsingTests.swift 85.38% <0%> (ø) ⬆️
Tests/SWXMLHashTests/WhiteSpaceParsingTests.swift 75% <0%> (ø) ⬆️
...LHashTests/TypeConversionPrimitypeTypesTests.swift 67.39% <0%> (ø) ⬆️
...XMLHashTests/TypeConversionComplexTypesTests.swift 66.66% <66.66%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8886e21...ee23560. Read the comment docs.

@drmohundro drmohundro merged commit fd1783d into master Jan 22, 2020
@drmohundro drmohundro deleted the bump-lint-versions branch January 22, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant