-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename SWXMLHash class to XMLHash #246
Conversation
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 74.34% 74.34%
=======================================
Files 14 14
Lines 1910 1910
=======================================
Hits 1420 1420
Misses 490 490
Continue to review full report at Codecov.
|
In Texas and just getting power and everything back to "normal". Will try this out as soon as I can. |
@fgarciaDev no worries, totally understand, I've got family in Texas. Stay safe and warm! |
Tested by specifying this branch in my Swift.Package manifest file. Rebuilt my XCFramework and was able to integrate into new projects without the need to manually edit the generated *.swiftinterface files for this library. Appreciate the work! |
Sounds great! I'd like to at least think about making some possible enhancements as this will be a major version bump. Not at all required, though, but that's my thought process. Sounds like you're good with referring to the branch still, correct? I don't want to cause any blockers for you, though, if I do that. |
yes, pointing to your dev branch is fine for now. appreciate it! |
b40f525
to
70c4edf
Compare
70c4edf
to
784f861
Compare
Related to #242, see comment specifically at #242 (comment).
When creating an XCFramework and the .swiftinterface file is created, there are name conflicts. The expectation is that classes within a module wouldn't share the name with the module. Other OSS libraries like this (e.g. Alamofire) have introduced a new name like
AF
.Of course, the hardest part here is naming... in this case, I just went with
XMLHash
by taking theSW
prefix off.I'm still open to other names for the actual type, though.
Things I want to understand prior to merging: