templates: add checks for payload length and array size #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugobliterator
force-pushed
the
pr-check-payload-array-size
branch
from
5ccba23 to
dbb67a9
Compare
tridge
requested changes
Feb 10, 2024
| @@ -166,7 +169,9 @@ void _@(msg_underscored_name)_decode(const CanardRxTransfer* transfer, uint32_t* | |||
| @(ind)(void)bit_ofs; | |||
| @(ind)(void)msg; | |||
| @(ind)(void)tao; | |||
|
|
|||
| @(ind)if (tao && (transfer->payload_len > @(msg_define_name.upper())_MAX_SIZE)) { | |||
There was a problem hiding this comment.
we need this to be in the function above so we can return true to indicate a bad decode. Note that relying on bit_ofs to detect that we haven't decoded is not sufficient
templates/msg.h.em
Outdated
| @@ -232,6 +237,9 @@ void _@(msg_underscored_name)_decode(const CanardRxTransfer* transfer, uint32_t* | |||
| @[ end if]@ | |||
| @{indent += 1}@{ind = ' '*indent}@ | |||
| @[ end if]@ | |||
| @(ind)if (msg->@(field.name).len > @(field.type.max_size)) { | |||
| @(ind) msg->@(field.name).len = @(field.type.max_size); | |||
There was a problem hiding this comment.
i think we should change these void functions to bool. Unfortunately the convention is return true on invalid decode (that is completely crazy btw)
There was a problem hiding this comment.
i think we should change these void functions to bool. Unfortunately the convention is return true on invalid decode (that is completely crazy btw)
The return true is to match the older version of the compiler.
use pragma for type limits
tridge
force-pushed
the
pr-check-payload-array-size
branch
from
71af5c9 to
e8f8a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.