prevent sending partial multi-frame transfers #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check that we have sufficient blocks available in the allocator before we start a multi-frame transfer to ensure we don't send a corrupt message by sending a subset of the frames. This can prevent a bus overload condition where the sender retries on a failed transfer, but the failed transfer consumes bus traffic and reduces the number of blocks available for the next transfer
bugobliterator
approved these changes
Sep 24, 2024
bugobliterator
previously requested changes
Sep 24, 2024
frame_max_data_len is a local which is 64 on CANFD, 8 on bCAN, so I think this properly handles CANFD already |
tridge
dismissed
bugobliterator’s stale review
CANFD is already correctly handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check that we have sufficient blocks available in the allocator before we start a multi-frame transfer to ensure we don't send a corrupt message by sending a subset of the frames. This can prevent a bus overload condition where the sender retries on a failed transfer, but the failed transfer consumes bus traffic and reduces the number of blocks available for the next transfer