Rewrite codegen in Rust #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely removes the dependency on Python, and especially the Python protobuf package.
pb-jelly-gen now depends on code that it generated for the various descriptors used by protoc as well as
rust/extensions.proto. These are bundled into the crate using a newly added "single file" output mode to avoid needing to publish separate crates. The generated code is also checked in for bootstrapping.For now this is mostly a 1:1 straight port of the original Python code. Boxing recursive fields was changed to use a side set as it's hard to mutate the original protos in-place (and pb-jelly support for extensions is read-only anyway).
Using pb-jelly-gen as a library no longer needs to create virtualenvs or run the plugin separately; instead it uses protoc's support for dumping parsed protos into a FileDescriptorSet and invokes the codegen "plugin" directly. A binary plugin target is still provided for direct use with protoc though.