Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve warning for missing assign in GRPCWithOptions plugin #8

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

aj-foster
Copy link
Contributor

Hi there 👋🏼

When using the GRPCWithOptions plugin, a warning is emitted (twice):

warning: assign @module_doc? not available in EEx template. Please ensure all assigns are given as options. Available assigns: [:module, :service_name, :methods, :descriptor_fun_body, :version]
  (eex 1.17.3) lib/eex/engine.ex:140: EEx.Engine.fetch_assign!/2
  (elixir 1.17.3) src/elixir.erl:386: :elixir.eval_external_handler/3
  (stdlib 6.1.2) erl_eval.erl:904: :erl_eval.do_apply/7
  (stdlib 6.1.2) erl_eval.erl:479: :erl_eval.expr/6
  (stdlib 6.1.2) erl_eval.erl:648: :erl_eval.expr/6
  (stdlib 6.1.2) erl_eval.erl:271: :erl_eval.exprs/6

This PR resolves the issue by creating a @module_doc? assign similar to the one available in the GRPC plugin.

❤️

@drowzy drowzy merged commit a249e5f into drowzy:main Nov 29, 2024
1 check passed
@drowzy
Copy link
Owner

drowzy commented Nov 29, 2024

Thanks 😄!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants