Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage instructions for tome:init #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rdancer
Copy link

@rdancer rdancer commented Feb 27, 2019

tome:init requires site:init be run first to set up the database connection; update the guide, and add a section on how to create a new database and user, so that one can simply create a new tome project just by following the instructions here, without the need of any previous knowledge.

`tome:init` requires `site:init` be run first to set up the database connection; update the guide, and add a section on how to create a new database and user, so that one can simply create a new tome project just by following the instructions here, without the need of any previous knowledge.
Fix usage instructions for `tome:init`
@stevector
Copy link

Hi @rdancer, I've only toyed with Tome but I haven't had trouble with the instructions as written. Do you get error messages when running tome:init immediately after the composer create-project drupal-tome/tome-project my_site --stability dev --no-interaction?

This pull request suggests using drupal-tome/tome-project as a dependency rather than as a project template which it is meant to be. That seems odd. As a project template this repo includes sqlite configuration which makes the manual MariaDB steps unnecessary.

mkdir my_site
cd my_site
composer create-project drupal-composer/drupal-project:8.x-dev . # <-- the dot at the end means current directory
composer require drupal-tome/tome-project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer projects are never added as dependencies - they're just templates for new projects. The previous instructions were correct here.

composer update
```

Create new SQL database `testdb`, with its own separate user `tome` that has all privileges for that database and only for that database, with a password `mypassword`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project is set up to use SQLite by default, which should work. If you want to add alternative instructions for MySQL I would put that under another heading as it should not be required.

@mortenson
Copy link
Contributor

I agree with @stevector but am interested in knowing what problems you ran into with the current instructions. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants