fix: role for section element with no accessible name #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Relates to #25
Updates the role returned for a
section
element to be either:region
when the element has an accessible name;generic
otherwise.How to Review
Mirrors the existing functionality and tests for the
img
element which has similar behaviours.According to specification a
title
attribute can also be used for the accessible name - I have opted to follow precedent set by theimg
behaviour to not include this (indeed there is prior art for ignoring thetitle
attribute in other pages IIRC as something seen as poor practice).Checklist