fix: role for th element in context #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Relates to #25
Updates the role returned for a
th
element to be either:columnheader
when thescope
iscol
orcolgroup
;rowheader
when thescope
isrow
orrowgroup
;gridcell
when the element is nested within atable
element with rolegrid
ortreegrid
;cell
when the element is nested within atable
element otherwise;columnheader
otherwise per the existing precedent to return a sensible defaults unless empty ancestors are explicitly provided.This detail is currently missing from the HTML-ARIA spec, but is describe in the sibling HTML-AAM spec:
How to Review
Nothing of note.
Checklist