Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerPermission: Added support for assigning permissions to a server role. #2061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IAMJDA
Copy link

@IAMJDA IAMJDA commented Feb 23, 2025

Pull Request (PR) description

Updated Set-SqlDscServerPermission to be able to set permission on server roles. Adapted unit tests so they should continue to work but missing support for the new logic.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@IAMJDA IAMJDA requested review from johlju and a team as code owners February 23, 2025 16:48
…ts for new logic bug haven't added explicit tests for roles
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93%. Comparing base (85ea1ed) to head (57aecc3).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           main   #2061     +/-   ##
======================================
- Coverage    94%     93%     -1%     
======================================
  Files        94      36     -58     
  Lines      7930    6341   -1589     
======================================
- Hits       7500    5953   -1547     
+ Misses      430     388     -42     
Flag Coverage Δ
unit 93% <ø> (-1%) ⬇️

see 58 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set-SqlDscServerPermission: Not possible to set server permissions for a server role
1 participant