Added blog post 'Realizing maintenance windows with DSC' #50
Conversation
|
I'll give this a review tomorrow if you like. Just short a bit of time today. |
|
I'll review that next week (Tue/Wed). |
|
Got the message, thanks guys :) |
Spelling and sanity check
Update dsc-maintenance-windows.en.md
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on @gaelcolas and @raandree)
content/blog/dsc-maintenance-windows.en.md, line 5 at r2 (raw file):
date: 2019-08-08T18:11:05+02:00 type: "post" draft: false
please add author: "raandree" in the meta field. That's how I plan to link back the author to the GitHub bio/pic for authors, as Johan did for the maintainers.
content/blog/dsc-maintenance-windows.en.md, line 9 at r2 (raw file):
## Author Raimund Andree is a Premier Field Engineer working for Microsoft in Germany. His work is mainly about DevOps in the Microsoft space using Azure DevOps, DSC and PowerShell. He is sharing the experience gained at PowerShell conferences, community days and while working on the projects [AutomatedLab](https://github.com/AutomatedLab/AutomatedLab) and [DscWorkshop](https://github.com/AutomatedLab/DscWorkshop).
Please keep your lines at or below 80 char. If you install the Markdownlint vscode extension, it should help you showing those type of format issues.
It makes reviewing easier.
content/blog/dsc-maintenance-windows.en.md, line 10 at r2 (raw file):
## Author Raimund Andree is a Premier Field Engineer working for Microsoft in Germany. His work is mainly about DevOps in the Microsoft space using Azure DevOps, DSC and PowerShell. He is sharing the experience gained at PowerShell conferences, community days and while working on the projects [AutomatedLab](https://github.com/AutomatedLab/AutomatedLab) and [DscWorkshop](https://github.com/AutomatedLab/DscWorkshop).
Please remove the author bits. I know it's not ideal but we'll look at providing a space for that (and a card either on the side or somewhere on the page).
If you can't wait, please move to the bottom.
content/blog/dsc-maintenance-windows.en.md, line 17 at r2 (raw file):
Since... I have been
Just a grammar rule I seem to remember:
When since introduces a state in the past that is still continuing in the present, we use a present perfect form of the verb after since and a present perfect form of the verb in the main clause:
Since I’ve been back at work, I’ve been feeling great.
https://dictionary.cambridge.org/grammar/british-grammar/linking-words-and-expressions/since
content/blog/dsc-maintenance-windows.en.md, line 18 at r2 (raw file):
This article summarizes the ideas and technical implementations I have worked on with...
content/blog/dsc-maintenance-windows.en.md, line 174 at r2 (raw file):
20:00
The h is confusing in that notation. I know some countries also use the 20h00 notation, but it's less understood than 20:00. You can also just use 2000, just a bit less obvious IMO.
|
Submitted issue #53 to track the narrow blog pages. Labelled it help wanted. |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on @gaelcolas)
content/blog/dsc-maintenance-windows.en.md, line 5 at r2 (raw file):
Previously, gaelcolas (Gael) wrote…
please add author: "raandree" in the meta field. That's how I plan to link back the author to the GitHub bio/pic for authors, as Johan did for the maintainers.
Done.
content/blog/dsc-maintenance-windows.en.md, line 9 at r2 (raw file):
Previously, gaelcolas (Gael) wrote…
Please keep your lines at or below 80 char. If you install the Markdownlint vscode extension, it should help you showing those type of format issues.
It makes reviewing easier.
Daniel required the same for the help and code provided to DSC resources. His argument for this requirement was that lines more than 80 characters are hard to review in this tool here. However, we loose the flow when we cut all lines at 80 chars. Why is this limit? Why 80 chars?
content/blog/dsc-maintenance-windows.en.md, line 10 at r2 (raw file):
Previously, gaelcolas (Gael) wrote…
## Author Raimund Andree is a Premier Field Engineer working for Microsoft in Germany. His work is mainly about DevOps in the Microsoft space using Azure DevOps, DSC and PowerShell. He is sharing the experience gained at PowerShell conferences, community days and while working on the projects [AutomatedLab](https://github.com/AutomatedLab/AutomatedLab) and [DscWorkshop](https://github.com/AutomatedLab/DscWorkshop).Please remove the author bits. I know it's not ideal but we'll look at providing a space for that (and a card either on the side or somewhere on the page).
If you can't wait, please move to the bottom.
Done.
content/blog/dsc-maintenance-windows.en.md, line 17 at r2 (raw file):
Previously, gaelcolas (Gael) wrote…
Since... I have been
Just a grammar rule I seem to remember:
When since introduces a state in the past that is still continuing in the present, we use a present perfect form of the verb after since and a present perfect form of the verb in the main clause:
Since I’ve been back at work, I’ve been feeling great.
https://dictionary.cambridge.org/grammar/british-grammar/linking-words-and-expressions/since
Done.
content/blog/dsc-maintenance-windows.en.md, line 18 at r2 (raw file):
Previously, gaelcolas (Gael) wrote…
This article summarizes the ideas and technical implementations I have worked on with...
Done.
content/blog/dsc-maintenance-windows.en.md, line 174 at r2 (raw file):
Previously, gaelcolas (Gael) wrote…
20:00
The h is confusing in that notation. I know some countries also use the 20h00 notation, but it's less understood than 20:00. You can also just use 2000, just a bit less obvious IMO.
Done.
|
@raandree do you have more edit coming or do you feel that's ready? |
|
I think the post is ready. If the change the design another smaller edit may be required. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @raandree)
content/blog/dsc-maintenance-windows.en.md, line 9 at r2 (raw file):
Previously, raandree (Raimund Andrée [MSFT]) wrote…
Daniel required the same for the help and code provided to DSC resources. His argument for this requirement was that lines more than 80 characters are hard to review in this tool here. However, we loose the flow when we cut all lines at 80 chars. Why is this limit? Why 80 chars?
So, it's not my favourite rule either, but I understand the reasoning.
With MD file, even if you add a in source, it does not break the sentence when rendered.
With git and revision tools, if you have a paragraph on one line (that could be of how many words you want), when something even tiny changes in that line, the paragraph (remember, single line) will show up a change, so it might be difficult to spot what actually changed.
By enforcing a smaller number of char per line, even a small edit would limit the change to a line of a dozen words (instead of the full paragraph).
Once vscode is setup, it's just an habit to get into... Although 80 char is pretty small, unless you're on mobile.
|
I don't want the cosmetic change (line length) to be blocking this time, but please understand we'd love if you could fix it one day ;) |
@gaelcolas, here it is. Can you correct the typos that you have found, please?
Two more questions in the blog in general:
How do you want to deal with the author information? I have added a small section (which does not render well)
The rendering with hugo is fine but the text column is pretty narrow. This is how the page looks like at the 1920x1200 resolution:
Is is possible to make the text column adapt dynamically to the browser window?
This change is