-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making container fluid to fix #53 #54
Conversation
That looks way better! |
Yeah I think is looks good. Merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we feel this is ugly in some places, we can just make a layout/template for those pages that uses container
.
Hmm, I actual tested this on my laptop and in an RDP session with lower resolution, and thought it looked okay. But on a large screen 2400> this messes up the other parts of the site. I will revert this change and I think we need to make a template for just the blog section. |
hum, who does look at a website on a very large screen without splitting? maybe we can add a max width...? |
@gaelcolas the blog section, style guideline and community notes could use the fluid |
Well, probably many ;) |
Max width could work. 🤔 |
We used a separate template for maintainers, so easy enough to add template for the sections we need more width on. 🤔 |
Hey team, here's an attempt to fix #53
I'm using bootstrap
container-fluid
class (instead of container).Let me know if you prefer that.
This change is