Avoid extra std::function layer in func::make
#546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharlet
force-pushed
the
ds/call-lambda
branch
from
d4eb297 to
05c6900
Compare
dsharlet
force-pushed
the
ds/call-lambda
branch
from
28e5c01 to
7b930bc
Compare
steven-johnson
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the lambda version of
func::make, we currently get two layers ofstd::function: one forcall_stmt::callable, which is unavoidable, but the other is just a wrapper to change the arguments, and doesn't need to be anstd::function, which adds some extra overhead.This PR avoids the inner
std::function, calling the lambda directly instead.