Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable internet for node groups created from launch template #190

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

vradicevicds
Copy link
Contributor

Current state of the terraform-aws-blueprints creates additional security groups for the cluster and nodes. These security groups are only applied to the node group if a node group has launch template. Such security group are not sufficient for SIMPHERA deployment.
This PR removes creation and attachment of mentioned security groups to enable SIMPHERA to work correctly.
Removal of security groups does not affect node's security. Such configuration is already manually used as a fix. Also, primary cluster security group is still present and is attached to created node groups.

Terraform v1.9.4
on windows_amd64

  • provider registry.terraform.io/gavinbunney/kubectl v1.14.0
  • provider registry.terraform.io/hashicorp/aws v5.37.0
  • provider registry.terraform.io/hashicorp/cloudinit v2.3.4
  • provider registry.terraform.io/hashicorp/helm v2.13.2
  • provider registry.terraform.io/hashicorp/http v3.4.3
  • provider registry.terraform.io/hashicorp/kubernetes v2.30.0
  • provider registry.terraform.io/hashicorp/local v2.5.1
  • provider registry.terraform.io/hashicorp/null v3.2.2
  • provider registry.terraform.io/hashicorp/random v3.6.2
  • provider registry.terraform.io/hashicorp/tls v4.0.5
  • provider registry.terraform.io/terraform-aws-modules/http v2.4.1

@vradicevicds vradicevicds merged commit f6d1483 into main Jan 30, 2025
1 check passed
@vradicevicds vradicevicds deleted the disable_extra_sg branch January 30, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants