Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nineheavens.org #1672

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

rizkiv1
Copy link
Contributor

@rizkiv1 rizkiv1 commented Feb 14, 2025

No description provided.

@gamebeaker
Copy link
Collaborator

gamebeaker commented Feb 15, 2025

@rizkiv1 Thanks for the commit <3
Please revert the changes from plugin/jszip/dist/jszip.min.js.

@rizkiv1 rizkiv1 closed this Feb 17, 2025
@rizkiv1 rizkiv1 reopened this Feb 17, 2025
@rizkiv1
Copy link
Contributor Author

rizkiv1 commented Feb 17, 2025

Ok i'm sorry idk what am I doing, first time pull req.

@rizkiv1 rizkiv1 marked this pull request as draft February 17, 2025 07:48
@gamebeaker
Copy link
Collaborator

@rizkiv1 no problem i still see changes in jszip.min.js that shouldn't be there.
I would create a new branch and add all changes in this new branch and create a new pull request.
Here is documentation that could be helpfull Developer-guide
Especially this part Publish your changes/ branch

@rizkiv1
Copy link
Contributor Author

rizkiv1 commented Feb 17, 2025

Branch got deleted and recreated.

@rizkiv1 rizkiv1 marked this pull request as ready for review February 17, 2025 11:05
@gamebeaker gamebeaker merged commit 56b36a0 into dteviot:ExperimentalTabMode Feb 17, 2025
1 check passed
@gamebeaker
Copy link
Collaborator

@rizkiv1 thanks for your work.
Tested with:
https://nineheavens.org/story/i-am-the-madman-of-this-family/
https://nineheavens.org/story/trait-absorption-hunter/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants