Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser version fails to load XLSX file if cell contains ">" #124

Closed
arxcode opened this issue Apr 26, 2018 · 1 comment
Closed

Browser version fails to load XLSX file if cell contains ">" #124

arxcode opened this issue Apr 26, 2018 · 1 comment

Comments

@arxcode
Copy link

arxcode commented Apr 26, 2018

If I try to upload the Excel file Test_with_greater_than.xlsx with the in-browser variant of xlsx-populate (e.g. here but also with the latest version available via bower), I receive an error message:

IQc is not defined

The attached Excel file is a very simple file which just contains a single sheet with a ">" (greater than) sign in the first cell. You get the same result with "<" (less than) and also "&" (ampersand). I have created it with Microsoft Excel for Mac 16.12; however, the same results can also be achieved by using xlsx-populate to write a greater-than sign to a sheet.

I tried in Firefox 59.0.2 and Vivaldi/Chrome, so I think it is not a browser-specific glitch.

Running the debugger, it says the second line of the following the source is to blame:

  function parseEntity (parser) {
    var entity = parser.entity
    var entityLC = entity.toLowerCase()
    var num
    var numStr = ''

I think this is the same issue as #115, as it also gets the "IQc" error. And in turn I think it is this issue from the sax.js repository:

isaacs/sax-js#223

They say it was a bug in UglifyJS (mishoo/UglifyJS#2783) and has been fixed there. So maybe it would be sufficient to re-uglify with a newer uglify?

smoke added a commit to smoke/xlsx-populate that referenced this issue May 15, 2018
it seems some of the old referenced packages were producing bad builds
of `browser/*` that caused problems like `JQc is not defined`
see dtjohnson#130 (comment)
see mishoo/UglifyJS#2783
see dtjohnson#124
smoke added a commit to smoke/xlsx-populate that referenced this issue May 16, 2018
it seems some of the old referenced packages were producing bad builds
of `browser/*` that caused problems like `JQc is not defined`
see dtjohnson#130 (comment)
see mishoo/UglifyJS#2783

fixes dtjohnson#115
fixes dtjohnson#124
fixes dtjohnson#125
fixes dtjohnson#130
smoke added a commit to smoke/xlsx-populate that referenced this issue May 16, 2018
it seems some of the old referenced packages were producing bad builds
of `browser/*` that caused problems like `JQc is not defined`
see dtjohnson#130 (comment)
see mishoo/UglifyJS#2783

fixes dtjohnson#115
fixes dtjohnson#124
fixes dtjohnson#125
fixes dtjohnson#130
@dtjohnson
Copy link
Owner

Please try with v1.17.0. There is also a non-minified version available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants