[BUG]fix saga enableConcurrent without addBranchOrder bug

dtm-php · Mar 31, 2023 · 1b60067 · 1b60067
2 parents 21e308a + 2cf49e8
commit 1b60067
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Saga.php b/src/Saga.php
@@ -6,6 +6,7 @@
  *
  * @license  https://github.com/dtm-php/dtm-client/blob/master/LICENSE
  */
+
 namespace DtmClient;
 
 use DtmClient\Api\ApiInterface;
@@ -79,7 +80,7 @@ public function addConcurrentContext()
         if ($this->concurrent) {
             TransContext::setCustomData(json_encode([
                 'concurrent' => $this->concurrent,
-                'orders' => $this->orders,
+                'orders' => $this->orders ?: null,
             ]));
         }
     }

diff --git a/tests/Cases/SagaTest.php b/tests/Cases/SagaTest.php
@@ -103,6 +103,19 @@ public function testEnableConcurrent()
         $this->assertTrue($concurrent);
     }
 
+    public function testEnableConcurrentWithoutAddBranchOrders()
+    {
+        $api = \Mockery::mock(ApiInterface::class);
+
+        $saga = new Saga($api);
+        $saga->enableConcurrent();
+
+        $ordersProperty = new \ReflectionProperty($saga, 'orders');
+        $ordersProperty->setAccessible(true);
+        $orders = $ordersProperty->getValue($saga);
+        $this->assertSame(null, $orders ?: null);
+    }
+
     public function testSubmit()
     {
         $api = \Mockery::mock(ApiInterface::class);