Highlight diffs #27
Closed
Highlight diffs #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtolnay do you think it would be possible to merge this as is? Even this not-perfect diff is a way better than no diff at all |
dtolnay
force-pushed
the
diff
branch
3 times, most recently
from
c2c7a98 to
0e2c8ab
Compare
Merged
|
All the diff libraries were bad so I implemented a new one in https://github.com/dtolnay/dissimilar and used it for #42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to look like this:
Unfortunately we currently get pretty confusing diffs from the diffr-lib library -- mookid/diffr#27. I really don't want to do character-based or line-based diffs, and I haven't been able to find a better word-based diff library so far.
For now this is on hold until there is a better diff library for Rust.