Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Excel logger in dbt-core 1.9.0 #449

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix Excel logger in dbt-core 1.9.0 #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dbt/adapters/duckdb/plugins/excel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
from . import pd_utils
from ..utils import SourceConfig
from ..utils import TargetConfig
from dbt.logger import GLOBAL_LOGGER as logger
from dbt.adapters.events.logging import AdapterLogger

logger = AdapterLogger("DuckDB")


class Plugin(BasePlugin):
Expand Down
9 changes: 9 additions & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import resource
import subprocess
import time
from importlib import metadata

import duckdb
import pytest
Expand All @@ -23,6 +24,14 @@ def pytest_addoption(parser):
parser.addoption("--profile", action="store", default="memory", type=str)


def pytest_report_header() -> list[str]:
"""Return a list of strings to be displayed in the header of the report."""
return [
f"duckdb: {metadata.version('duckdb')}",
f"dbt-core: {metadata.version('dbt-core')}",
]


@pytest.fixture(scope="session")
def profile_type(request):
return request.config.getoption("--profile")
Expand Down
12 changes: 6 additions & 6 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[tox]
skipsdist = True
envlist = py38,py39,py310,py311
envlist = py{38,39,310,311,312}

[testenv:{unit,py38,py39,py310,py311,py}]
[testenv:{unit,py38,py39,py310,py311,py312,py}]
description = unit testing
skip_install = True
passenv = *
Expand All @@ -12,7 +12,7 @@ deps =
-e.


[testenv:{functional,py38,py39,py310,py311,py}]
[testenv:{functional,py38,py39,py310,py311,py312,py}]
description = adapter functional testing
skip_install = True
passenv = *
Expand All @@ -21,7 +21,7 @@ deps =
-rdev-requirements.txt
-e.

[testenv:{filebased,py38,py39,py310,py311,py}]
[testenv:{filebased,py38,py39,py310,py311,py312,py}]
description = adapter functional testing using file-based DBs
skip_install = True
passenv = *
Expand All @@ -48,7 +48,7 @@ deps =
-rdev-requirements.txt
-e.[md]

[testenv:{fsspec,py38,py39,py310,py311,py}]
[testenv:{fsspec,py38,py39,py310,py311,py312,py}]
description = adapter fsspec testing
skip_install = True
passenv = *
Expand All @@ -57,7 +57,7 @@ deps =
-rdev-requirements.txt
-e.

[testenv:{plugins,py38,py39,py310,py311,py}]
[testenv:{plugins,py38,py39,py310,py311,py312,py}]
description = adapter plugin testing
skip_install = True
passenv = *
Expand Down
Loading