Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring community/nightly extensions in the profile directly #450

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jwills
Copy link
Collaborator

@jwills jwills commented Oct 3, 2024

Wanted to have proper support for community/nightly extensions from dbt-duckdb for folks available in the profiles.yml without requiring pre-hooks to set them up.

@jwills jwills requested a review from guenp October 3, 2024 18:22
@guenp
Copy link
Collaborator

guenp commented Oct 3, 2024

Looks like the logger errors is because we have to change

from dbt.logger import GLOBAL_LOGGER as logger

into

from dbt.adapters.events.logging import AdapterLogger

logger = AdapterLogger("duckdb")

see https://github.com/dbt-labs/dbt-adapters/tree/main/dbt/adapters/events#adapter-maintainers

@jwills jwills force-pushed the jwills_install_from_support branch from b2171b2 to f87fbda Compare October 3, 2024 22:09
@jwills jwills force-pushed the jwills_install_from_support branch from f87fbda to a823db8 Compare October 3, 2024 23:07
@jwills jwills merged commit bbd04cc into master Oct 4, 2024
33 checks passed
@jwills jwills deleted the jwills_install_from_support branch October 4, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants