Update react-virtualized 9.22.3 to 9.22.4 #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dude0001
force-pushed
the
feature/react-virtualized-v9.22.4
branch
3 times, most recently
from
924a15d to
3160a90
Compare
|
@carlopi I've rebased this on main after the rename and fixed conflicts. It should be ready to go. |
dude0001
force-pushed
the
feature/react-virtualized-v9.22.4
branch
2 times, most recently
from
d257886 to
b11f154
Compare
dude0001
force-pushed
the
feature/react-virtualized-v9.22.4
branch
from
b11f154 to
616043a
Compare
|
@carlopi is there anything else I need to do to merge this one now that it is approved? Sorry, my first PR here and getting familiar with the process. I have a couple more changes I'm going to try to make to improve onboarding and maybe tackle an actual issue. |
|
PR is good to go, and other PRs are more than welcome! This will be merged in the next batch, likely tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package duckdb-wasm-app has a dependency on React v18. React v18 was added as a peer dependency to react-virtualized in v9.22.4.
The dependency is left pinned to 9.22.4 instead of allowing minor version upgrades. There is a new version of react-virtualized v9.22.5 published to npm. There is no tagged commit in the repository for this, and the changelog does not mention v9.22.5. It is understood 9.22.5 is the "NEXT" pre-release version that can wait to pull in.
The goal of this change is to make onboarding easier for new developers. This resolves warnings when running an initial
yarn installor errors running an initialnpm installafter cloning the repository.