Skip to content

Commit

Permalink
Show on App Launch: Use string resources for settings (#5549)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1202552961248957/1209246799465881/f

### Description
Replaced hardcoded strings with string resources in the app launch
settings screen for better localization support. Updated text references
for "Last Opened Tab," "New Tab Page," and "Specific Page" options.

### Steps to test this PR

_String Resources Implementation_
- [x] Navigate to Show on App launch settings
- [x] Verify "Last Opened Tab" displays correctly from string resources
- [x] Verify "New Tab Page" displays correctly from string resources
- [x] Verify "Specific Page" displays correctly from string resources
- [x] Test in different locales to ensure proper translation support

### UI changes
| Before  | After |
| ------ | ----- |

|![Screenshot_20250127_160409](https://github.com/user-attachments/assets/39c0ed22-a23a-4fe4-b137-c88cf04f2cf1)|![Screenshot_20250127_161411](https://github.com/user-attachments/assets/40026550-b30a-46bd-9e9e-89b45362c4cc)|
  • Loading branch information
mikescamell authored Jan 27, 2025
1 parent 2f29dd4 commit 1b6e964
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,21 +41,21 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="@dimen/oneLineItemHeight"
app:primaryText="Last Opened Tab" />
app:primaryText="@string/showOnAppLaunchOptionLastOpenedTab" />

<com.duckduckgo.common.ui.view.listitem.RadioListItem
android:id="@+id/newTabCheckListItem"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="@dimen/oneLineItemHeight"
app:primaryText="New Tab Page" />
app:primaryText="@string/showOnAppLaunchOptionNewTabPage" />

<com.duckduckgo.common.ui.view.listitem.RadioListItem
android:id="@+id/specificPageCheckListItem"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:minHeight="@dimen/oneLineItemHeight"
app:primaryText="Specific Page" />
app:primaryText="@string/showOnAppLaunchOptionSpecificPage" />

<com.duckduckgo.common.ui.view.text.DaxTextInput
android:id="@+id/specificPageUrlInput"
Expand Down

0 comments on commit 1b6e964

Please sign in to comment.