UI for autofill breakage reports

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/reporting/remoteconfig/AutofillSiteBreakageReportingFeature.kt

@@ -28,6 +28,8 @@ interface AutofillSiteBreakageReportingFeature {
      * If the remote feature is not present defaults to `false`
      */
 
-    @Toggle.DefaultValue(false)
+    // hack reset this to false
+
+    @Toggle.DefaultValue(true)
     fun self(): Toggle
 }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillManagementRecyclerAdapter.kt

@@ -32,6 +32,7 @@ import com.duckduckgo.autofill.impl.R
 import com.duckduckgo.autofill.impl.databinding.ItemRowAutofillCredentialsManagementScreenBinding
 import com.duckduckgo.autofill.impl.databinding.ItemRowAutofillCredentialsManagementScreenDividerBinding
 import com.duckduckgo.autofill.impl.databinding.ItemRowAutofillCredentialsManagementScreenHeaderBinding
+import com.duckduckgo.autofill.impl.databinding.ItemRowAutofillReportBreakageManagementScreenBinding
 import com.duckduckgo.autofill.impl.databinding.ItemRowSearchNoResultsBinding
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter.ContextMenuAction.CopyPassword
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter.ContextMenuAction.CopyUsername
@@ -42,6 +43,7 @@ import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementR
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter.ListItem.Divider
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter.ListItem.GroupHeading
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter.ListItem.NoMatchingSearchResults
+import com.duckduckgo.autofill.impl.ui.credential.management.AutofillManagementRecyclerAdapter.ListItem.ReportAutofillBreakage
 import com.duckduckgo.autofill.impl.ui.credential.management.sorting.CredentialGrouper
 import com.duckduckgo.autofill.impl.ui.credential.management.sorting.InitialExtractor
 import com.duckduckgo.autofill.impl.ui.credential.management.suggestion.SuggestionListBuilder
@@ -59,6 +61,7 @@ class AutofillManagementRecyclerAdapter(
     private val suggestionListBuilder: SuggestionListBuilder,
     private val onCredentialSelected: (credentials: LoginCredentials) -> Unit,
     private val onContextMenuItemClicked: (ContextMenuAction) -> Unit,
+    private val onReportBreakageClicked: () -> Unit,
 ) : Adapter<RecyclerView.ViewHolder>() {
 
     private var listItems = listOf<ListItem>()
@@ -93,6 +96,11 @@ class AutofillManagementRecyclerAdapter(
                 NoMatchingSearchResultsViewHolder(binding)
             }
 
+            ITEM_VIEW_TYPE_REPORT_AUTOFILL_BREAKAGE -> {
+                val binding = ItemRowAutofillReportBreakageManagementScreenBinding.inflate(LayoutInflater.from(parent.context), parent, false)
+                ReportBreakageViewHolder(binding)
+            }
+
             else -> throw IllegalArgumentException("Unknown view type")
         }
     }
@@ -106,6 +114,7 @@ class AutofillManagementRecyclerAdapter(
             is CredentialsViewHolder -> onBindViewHolderCredential(position, viewHolder)
             is HeadingViewHolder -> onBindViewHolderHeading(position, viewHolder)
             is NoMatchingSearchResultsViewHolder -> onBindViewHolderNoMatchingSearchResults(position, viewHolder)
+            is ReportBreakageViewHolder -> onBindViewHolderReportBreakage(viewHolder)
         }
     }
 
@@ -118,6 +127,12 @@ class AutofillManagementRecyclerAdapter(
         viewHolder.binding.noMatchingLoginsHint.text = formattedNoResultsText
     }
 
+    private fun onBindViewHolderReportBreakage(viewHolder: ReportBreakageViewHolder) {
+        viewHolder.binding.root.setOnClickListener {
+            onReportBreakageClicked()
+        }
+    }
+
     private fun onBindViewHolderCredential(
         position: Int,
         viewHolder: CredentialsViewHolder,
@@ -169,6 +184,7 @@ class AutofillManagementRecyclerAdapter(
             is SuggestedCredential -> ITEM_VIEW_TYPE_SUGGESTED_CREDENTIAL
             is Divider -> ITEM_VIEW_TYPE_DIVIDER
             is NoMatchingSearchResults -> ITEM_VIEW_TYPE_NO_MATCHING_SEARCH_RESULTS
+            is ReportAutofillBreakage -> ITEM_VIEW_TYPE_REPORT_AUTOFILL_BREAKAGE
         }
     }
 
@@ -206,10 +222,11 @@ class AutofillManagementRecyclerAdapter(
         unsortedCredentials: List<LoginCredentials>,
         unsortedDirectSuggestions: List<LoginCredentials>,
         unsortedSharableSuggestions: List<LoginCredentials>,
+        allowBreakageReporting: Boolean,
     ) {
         val newList = mutableListOf<ListItem>()
 
-        val directSuggestionsListItems = suggestionListBuilder.build(unsortedDirectSuggestions, unsortedSharableSuggestions)
+        val directSuggestionsListItems = suggestionListBuilder.build(unsortedDirectSuggestions, unsortedSharableSuggestions, allowBreakageReporting)
         newList.addAll(directSuggestionsListItems)
 
         val groupedCredentials = grouper.group(unsortedCredentials)
@@ -239,16 +256,17 @@ class AutofillManagementRecyclerAdapter(
             data class Credential(override val credentials: LoginCredentials) : CredentialListItem(credentials)
             data class SuggestedCredential(override val credentials: LoginCredentials) : CredentialListItem(credentials)
         }
-
+        data object ReportAutofillBreakage : ListItem
         data class GroupHeading(val label: String) : ListItem
-        object Divider : ListItem
+        data object Divider : ListItem
         data class NoMatchingSearchResults(val query: String) : ListItem
     }
 
     open class CredentialsViewHolder(open val binding: ItemRowAutofillCredentialsManagementScreenBinding) : RecyclerView.ViewHolder(binding.root)
     class SuggestedCredentialsViewHolder(override val binding: ItemRowAutofillCredentialsManagementScreenBinding) : CredentialsViewHolder(binding)
     class HeadingViewHolder(val binding: ItemRowAutofillCredentialsManagementScreenHeaderBinding) : RecyclerView.ViewHolder(binding.root)
     class DividerViewHolder(val binding: ItemRowAutofillCredentialsManagementScreenDividerBinding) : RecyclerView.ViewHolder(binding.root)
+    class ReportBreakageViewHolder(val binding: ItemRowAutofillReportBreakageManagementScreenBinding) : RecyclerView.ViewHolder(binding.root)
     class NoMatchingSearchResultsViewHolder(val binding: ItemRowSearchNoResultsBinding) : RecyclerView.ViewHolder(binding.root)
 
     companion object {
@@ -257,5 +275,6 @@ class AutofillManagementRecyclerAdapter(
         private const val ITEM_VIEW_TYPE_SUGGESTED_CREDENTIAL = 2
         private const val ITEM_VIEW_TYPE_DIVIDER = 3
         private const val ITEM_VIEW_TYPE_NO_MATCHING_SEARCH_RESULTS = 4
+        private const val ITEM_VIEW_TYPE_REPORT_AUTOFILL_BREAKAGE = 5
     }
 }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillSettingsViewModel.kt

@@ -40,6 +40,7 @@ import com.duckduckgo.autofill.impl.pixel.AutofillPixelNames.AUTOFILL_MANUALLY_S
 import com.duckduckgo.autofill.impl.pixel.AutofillPixelNames.AUTOFILL_NEVER_SAVE_FOR_THIS_SITE_CONFIRMATION_PROMPT_CONFIRMED
 import com.duckduckgo.autofill.impl.pixel.AutofillPixelNames.AUTOFILL_NEVER_SAVE_FOR_THIS_SITE_CONFIRMATION_PROMPT_DISMISSED
 import com.duckduckgo.autofill.impl.pixel.AutofillPixelNames.AUTOFILL_NEVER_SAVE_FOR_THIS_SITE_CONFIRMATION_PROMPT_DISPLAYED
+import com.duckduckgo.autofill.impl.reporting.remoteconfig.AutofillSiteBreakageReportingFeature
 import com.duckduckgo.autofill.impl.store.InternalAutofillStore
 import com.duckduckgo.autofill.impl.store.NeverSavedSiteRepository
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillSettingsViewModel.Command.ExitCredentialMode
@@ -74,6 +75,7 @@ import com.duckduckgo.autofill.impl.ui.credential.management.AutofillSettingsVie
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillSettingsViewModel.DuckAddressStatus.SettingActivationStatus
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillSettingsViewModel.ListModeCommand.LaunchDeleteAllPasswordsConfirmation
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillSettingsViewModel.ListModeCommand.LaunchImportPasswords
+import com.duckduckgo.autofill.impl.ui.credential.management.AutofillSettingsViewModel.ListModeCommand.LaunchReportAutofillBreakageConfirmation
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillSettingsViewModel.ListModeCommand.LaunchResetNeverSaveListConfirmation
 import com.duckduckgo.autofill.impl.ui.credential.management.AutofillSettingsViewModel.ListModeCommand.PromptUserToAuthenticateMassDeletion
 import com.duckduckgo.autofill.impl.ui.credential.management.neversaved.NeverSavedSitesViewState
@@ -83,6 +85,8 @@ import com.duckduckgo.autofill.impl.ui.credential.management.survey.SurveyDetail
 import com.duckduckgo.autofill.impl.ui.credential.management.viewing.duckaddress.DuckAddressIdentifier
 import com.duckduckgo.autofill.impl.ui.credential.repository.DuckAddressStatusRepository
 import com.duckduckgo.autofill.impl.ui.credential.repository.DuckAddressStatusRepository.ActivationStatusResult
+import com.duckduckgo.autofill.impl.urlmatcher.AutofillUrlMatcher
+import com.duckduckgo.autofill.store.reporting.AutofillSiteBreakageReportingFeatureRepository
 import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.di.scopes.ActivityScope
 import com.duckduckgo.sync.api.engine.SyncEngine
@@ -117,6 +121,9 @@ class AutofillSettingsViewModel @Inject constructor(
     private val syncEngine: SyncEngine,
     private val neverSavedSiteRepository: NeverSavedSiteRepository,
     private val autofillSurvey: AutofillSurvey,
+    private val reportBreakageFeature: AutofillSiteBreakageReportingFeature,
+    private val reportBreakageFeatureExceptions: AutofillSiteBreakageReportingFeatureRepository,
+    private val urlMatcher: AutofillUrlMatcher,
 ) : ViewModel() {
 
     private val _viewState = MutableStateFlow(ViewState())
@@ -144,6 +151,8 @@ class AutofillSettingsViewModel @Inject constructor(
 
     private var combineJob: Job? = null
 
+    private var currentUrl: String? = null
+
     fun onCopyUsername(username: String?) {
         username?.let { clipboardInteractor.copyToClipboard(it, isSensitive = false) }
         pixel.fire(AutofillPixelNames.AUTOFILL_COPY_USERNAME)
@@ -407,13 +416,15 @@ class AutofillSettingsViewModel @Inject constructor(
         if (combineJob != null) return
         combineJob = viewModelScope.launch(dispatchers.io()) {
             _viewState.value = _viewState.value.copy(autofillEnabled = autofillStore.autofillEnabled)
+
             val allCredentials = autofillStore.getAllCredentials().distinctUntilChanged()
             val combined = allCredentials.combine(searchQueryFilter) { credentials, filter ->
                 credentialListFilter.filter(credentials, filter)
             }
             combined.collect { credentials ->
                 _viewState.value = _viewState.value.copy(
                     logins = credentials,
+                    allowBreakageReporting = isBreakageReportingAllowed(),
                 )
             }
         }
@@ -425,6 +436,15 @@ class AutofillSettingsViewModel @Inject constructor(
         }
     }
 
+    private fun isBreakageReportingAllowed(): Boolean {
+        val url = currentUrl ?: return false
+        val urlParts = urlMatcher.extractUrlPartsForAutofill(url)
+
+        return (reportBreakageFeature.self().isEnabled() && !reportBreakageFeatureExceptions.exceptions.contains(urlParts.eTldPlus1)).also {
+            Timber.v("Allow breakage reporting for [%s]: %s", urlParts, it)
+        }
+    }
+
     fun onDeleteCurrentCredentials() {
         getCurrentCredentials()?.let {
             onDeleteCredentials(it)
@@ -688,12 +708,34 @@ class AutofillSettingsViewModel @Inject constructor(
         addCommand(LaunchImportPasswords)
     }
 
+    fun onReportBreakageClicked() {
+        val eTldPlusOne = urlMatcher.extractUrlPartsForAutofill(currentUrl).eTldPlus1
+        if (eTldPlusOne != null) {
+            addCommand(LaunchReportAutofillBreakageConfirmation(eTldPlusOne))
+        }
+    }
+
+    fun updateCurrentUrl(currentUrl: String?) {
+        this.currentUrl = currentUrl
+    }
+
+    fun userConfirmedSendBreakageReport(eTldPlusOne: String) {
+        // todo send the pixel
+
+        // todo record feedback sent timestamp for this domain. todo - work out where to record this
+
+        _viewState.value = _viewState.value.copy(allowBreakageReporting = false)
+
+        addCommand(ListModeCommand.ShowUserReportSentMessage)
+    }
+
     data class ViewState(
         val autofillEnabled: Boolean = true,
         val showAutofillEnabledToggle: Boolean = true,
         val logins: List<LoginCredentials>? = null,
         val credentialMode: CredentialMode? = null,
         val credentialSearchQuery: String = "",
+        val allowBreakageReporting: Boolean = false,
         val survey: SurveyDetails? = null,
     )
 
@@ -764,6 +806,8 @@ class AutofillSettingsViewModel @Inject constructor(
         data class LaunchDeleteAllPasswordsConfirmation(val numberToDelete: Int) : ListModeCommand()
         data class PromptUserToAuthenticateMassDeletion(val authConfiguration: AuthConfiguration) : ListModeCommand()
         data object LaunchImportPasswords : ListModeCommand()
+        data class LaunchReportAutofillBreakageConfirmation(val eTldPlusOne: String) : ListModeCommand()
+        data object ShowUserReportSentMessage : ListModeCommand()
     }
 
     sealed class DuckAddressStatus {

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/ui/credential/management/suggestion/SuggestionListBuilder.kt

@@ -34,6 +34,7 @@ class SuggestionListBuilder @Inject constructor(
     fun build(
         unsortedDirectSuggestions: List<LoginCredentials>,
         unsortedSharableSuggestions: List<LoginCredentials>,
+        allowBreakageReporting: Boolean,
     ): List<ListItem> {
         val list = mutableListOf<ListItem>()
 
@@ -46,6 +47,10 @@ class SuggestionListBuilder @Inject constructor(
             val allSuggestions = sortedDirectSuggestions + sortedSharableSuggestions
             list.addAll(allSuggestions.map { SuggestedCredential(it) })
 
+            if (allowBreakageReporting) {
+                list.add(ListItem.ReportAutofillBreakage)
+            }
+
             list.add(Divider)
         }