Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize macos namespace #3818

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Standardize macos namespace #3818

merged 1 commit into from
Nov 14, 2023

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Nov 7, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1205884745797986/f

Description

Changes macos-impl namespace from com.duckduckgo.macos_impl to com.duckduckgo.macos.impl

Steps to test this PR

  • Test that Settings > DuckDuckGo Mac App works correctly

This was referenced Nov 7, 2023
Merged
Merged
Merged
Merged
@joshliebe
Copy link
Contributor Author

joshliebe commented Nov 7, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@joshliebe joshliebe mentioned this pull request Nov 7, 2023
Merged
1 task
@joshliebe joshliebe force-pushed the feature/josh/standardize-macos-namespace branch from c74a217 to fc9a4b1 Compare November 7, 2023 16:11
@joshliebe joshliebe force-pushed the feature/josh/update-to-agp-8.1.0 branch 2 times, most recently from 90aad1d to 60f9d72 Compare November 13, 2023 20:44
@joshliebe joshliebe force-pushed the feature/josh/standardize-macos-namespace branch 2 times, most recently from 973904c to aec8a94 Compare November 13, 2023 22:37
@joshliebe joshliebe marked this pull request as ready for review November 13, 2023 22:48
marcosholgado
marcosholgado approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshliebe joshliebe force-pushed the feature/josh/update-to-agp-8.1.0 branch from 60f9d72 to b11f073 Compare November 14, 2023 09:50
@joshliebe joshliebe mentioned this pull request Nov 14, 2023
Merged
2 tasks
@joshliebe joshliebe force-pushed the feature/josh/update-to-agp-8.1.0 branch from b11f073 to f8d0d1f Compare November 14, 2023 10:49
@joshliebe joshliebe force-pushed the feature/josh/standardize-macos-namespace branch from aec8a94 to e1bee83 Compare November 14, 2023 10:49
@joshliebe joshliebe force-pushed the feature/josh/standardize-macos-namespace branch from e1bee83 to b67428b Compare November 14, 2023 11:32
@joshliebe joshliebe merged commit 47b900d into feature/josh/update-to-agp-8.1.0 Nov 14, 2023
4 checks passed
@joshliebe joshliebe deleted the feature/josh/standardize-macos-namespace branch November 14, 2023 11:53
joshliebe added a commit that referenced this pull request Nov 14, 2023
@joshliebe
Standardize macos namespace (#3818)
84e961e
joshliebe added a commit that referenced this pull request Nov 14, 2023
@joshliebe
Standardize macos namespace (#3818)
f8ae7f8
joshliebe added a commit that referenced this pull request Nov 14, 2023
@joshliebe
Standardize macos namespace (#3818)
993c121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosholgado marcosholgado marcosholgado approved these changes

@malmstein malmstein Awaiting requested review from malmstein

@nalcalag nalcalag Awaiting requested review from nalcalag

Assignees

@marcosholgado marcosholgado

Labels
STACKED PR - DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshliebe @marcosholgado