Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CheckListItem to common-ui #3947

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Move CheckListItem to common-ui #3947

merged 1 commit into from
Dec 4, 2023

Conversation

marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Nov 30, 2023 •
edited by nalcalag
Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1206070233895160/f

Description

This PR moves the CheckListItem to common-ui

Steps to test this PR

  • Install the app and play with settings a bit
  • All check items list should work as expected.

This was referenced Nov 30, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@marcosholgado
Copy link
Contributor Author

marcosholgado commented Nov 30, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@marcosholgado marcosholgado mentioned this pull request Nov 30, 2023
Merged
@nalcalag nalcalag self-assigned this Nov 30, 2023
nalcalag
nalcalag approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

This was referenced Dec 1, 2023
Merged
Merged
Base automatically changed from feature/marcos/link_email_account to develop December 4, 2023 09:47
@marcosholgado marcosholgado force-pushed the feature/marcos/move_check_list_item branch from 55d1a61 to 260818b Compare December 4, 2023 11:29
@marcosholgado marcosholgado merged commit ec2e95d into develop Dec 4, 2023
5 checks passed
@marcosholgado marcosholgado deleted the feature/marcos/move_check_list_item branch December 4, 2023 12:04
@marcosholgado marcosholgado mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalcalag nalcalag nalcalag approved these changes

@malmstein malmstein Awaiting requested review from malmstein malmstein is a code owner

Assignees

@nalcalag nalcalag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosholgado @nalcalag