Bottom sheet dialogs should dismiss instead of hiding when a button is pressed #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
CDRussell
commented
Dec 1, 2023
| @@ -54,11 +54,13 @@ class ActionBottomSheetDialog(builder: Builder) : BottomSheetDialog(builder.cont | |||
| setOnShowListener { builder.listener.onBottomSheetShown() } | |||
| binding.actionBottomSheetDialogPrimaryItem.setOnClickListener { | |||
| builder.listener.onPrimaryItemClicked() | |||
| hide() | |||
| setOnDismissListener(null) | |||
There was a problem hiding this comment.
not sure if it's worth creating a shared utility function for this... guessing not but open to it
There was a problem hiding this comment.
I think it's ok. It's clear enough and it won't save us lines of codes, so happy to leave it as it is
CDRussell
deleted the
fix/craig/ads_dialogs_should_dismiss_instead_of_hide
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1206077448728301/f
Description
When a button is pressed in the bottom sheet dialogs, ensure we
dismiss()instead ofhide()to prevent unintended side-effects depending on what the caller does not (as detailed in the linked task).Sets the dismiss listener to
nullbefore callingdismiss()to ensure we get only one of:Steps to test this PR
Action Botton Sheetworks as expectedPromo Bottom Sheetworks as expected