Backup service #3952
Merged
Backup service #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
nalcalag
commented
Dec 1, 2023
marcosholgado
requested changes
Dec 1, 2023
statistics/src/main/java/com/duckduckgo/app/statistics/DuckDuckGoBackupAgent.kt
Outdated
Show resolved
Hide resolved
2 tasks
nalcalag
force-pushed
the
feature/noelia/backup_service
branch
from
deb4ce3 to
e1dfc47
Compare
aitorvs
reviewed
Dec 3, 2023
...compiler/src/main/java/com/duckduckgo/anvil/compiler/ContributesSubComponentCodeGenerator.kt
Show resolved
Hide resolved
...compiler/src/main/java/com/duckduckgo/anvil/compiler/ContributesSubComponentCodeGenerator.kt
Show resolved
Hide resolved
statistics/src/main/java/com/duckduckgo/app/statistics/DuckDuckGoBackupAgent.kt
Outdated
Show resolved
Hide resolved
statistics/src/main/java/com/duckduckgo/app/statistics/DuckDuckGoBackupAgent.kt
Outdated
Show resolved
Hide resolved
aitorvs
reviewed
Dec 4, 2023
statistics/src/main/java/com/duckduckgo/app/statistics/DuckDuckGoBackupAgent.kt
Outdated
Show resolved
Hide resolved
nalcalag
force-pushed
the
feature/noelia/backup_service
branch
2 times, most recently
from
ba32243 to
6f3eb8a
Compare
…tisticsSharedPreferences
nalcalag
force-pushed
the
feature/noelia/backup_service
branch
from
6f3eb8a to
c221498
Compare
marcosholgado
approved these changes
Dec 4, 2023
Task/Issue URL: https://app.asana.com/0/488551667048375/1206059122944073/f ### Description Implementation for adding variant `ru` for returning users ### Steps to test this PR - Add a log in getVariantKey() implementation so you can check it's value _New user install_ - Install from this branch - Open logcat - [x] Check defaultVariant is allocated (_emptyString_) _Returning user install_ - Follow previous steps - Perform a backup: Run `./test_cloud_backup.sh com.duckduckgo.mobile.android.debug` in the terminal - Open the app - [x] Check `ru` variant is allocated to the user ### No UI changes
CDRussell
added a commit
that referenced
this pull request
Dec 11, 2023
This reverts commit cd9a695.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206040339100181/f
Description
Implemented backup key/value service
Steps to test this PR
ATB mapped to BackUp prefs
ReinstallAtbListenerto check preference mappingBackup service
./test_cloud_backup.sh com.duckduckgo.mobile.android.debugin the terminalPixel sent when Backup service enabled
./test_cloud_backup.sh com.duckduckgo.mobile.android.debugin the terminalm_backup_service_enabledpixel is sentNo UI changes