Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch exceptions when persisting bloom filter #4008

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Catch exceptions when persisting bloom filter #4008

merged 1 commit into from
Dec 15, 2023

Conversation

marcosholgado
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1206139533408464/f

Description

Capture exceptions when persisting bloom filter data.

Steps to test this PR

  • In persistBloomFilter() throw an exception within the runInTransaction block
  • Install the app
  • App should not crash

@marcosholgado
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@CDRussell CDRussell self-assigned this Dec 15, 2023
@marcosholgado marcosholgado merged commit 3b2e096 into develop Dec 15, 2023
7 checks passed
@marcosholgado marcosholgado deleted the fix/marcos/bloom_filter_exception branch December 15, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CDRussell CDRussell CDRussell approved these changes

Assignees

@CDRussell CDRussell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosholgado @CDRussell