Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support advanced syntax in SERP #4009

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Support advanced syntax in SERP #4009

merged 1 commit into from
Dec 17, 2023

Conversation

marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Dec 14, 2023 •
edited by aitorvs
Loading

Task/Issue URL: https://app.asana.com/0/414730916066338/1206153302008458/f

Description

This PR adds support for advanced syntax in SERP

Steps to test this PR

  • In the url bar type filetype:pdf, search should return different pdfs files
  • In the url bar type inurl:cat, search should return urls which contain the word cat
  • In the url bar type intitle:cat, search should return websites which title contains the word cat
  • None of the above should throw an Unable to open this type of link error in a toast

@marcosholgado
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

aitorvs
aitorvs approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcosholgado marcosholgado merged commit 6c6c54d into develop Dec 17, 2023
7 checks passed
@marcosholgado marcosholgado deleted the fix/marcos/advanced_syntax branch December 17, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitorvs aitorvs aitorvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosholgado @aitorvs