Sync: Usage Pixels and Monitoring #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
malmstein
force-pushed
the
feature/david/12-18-Sync_Pixels_and_Monitoring
branch
from
db12e77 to
fb28dd5
Compare
malmstein
changed the title
malmstein
force-pushed
the
feature/david/12-18-Sync_Pixels_and_Monitoring
branch
3 times, most recently
from
b513292 to
5faeb2b
Compare
malmstein
force-pushed
the
feature/david/12-18-Sync_Pixels_and_Monitoring
branch
from
5faeb2b to
0799bde
Compare
malmstein
force-pushed
the
feature/david/12-18-Sync_Pixels_and_Monitoring
branch
from
0799bde to
71aa730
Compare
joshliebe
reviewed
Dec 21, 2023
| @@ -25,6 +25,7 @@ import com.duckduckgo.sync.api.engine.SyncEngine.SyncTrigger.ACCOUNT_CREATION | |||
| import com.duckduckgo.sync.api.engine.SyncEngine.SyncTrigger.ACCOUNT_LOGIN | |||
| import com.duckduckgo.sync.crypto.* | |||
| import com.duckduckgo.sync.impl.Result.Error | |||
| import com.duckduckgo.sync.impl.Result.Success | |||
There was a problem hiding this comment.
A few unused imports in this file
joshliebe
approved these changes
Dec 21, 2023
|
Thanks @joshliebe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1206193954622385/f
Description
This PR adds the usage pixels for Sync
Steps to test this PR
Signup Direct
Fired when user sets up a sync account directly.
Signup Connect
Fired when user sets up a sync account from connect flow. You’ll need two devices for this one.
Login - Entering Code
Fired when adding new device to existing account. You’ll need two devices for this one.
Login - Scan QR
Fired when adding new device to existing account. You’ll need two devices for this one.
Login - Recover Account with Code
Fired when adding new device to existing account. You’ll need two devices for this one.
Login - Recover Account with QR
Fired when adding new device to existing account. You’ll need two devices for this one.
Daily pixel
Fired for first sync on a given day.