Add access revoked dialog #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
karlenDimla
force-pushed
the
feature/karl/netp/expired-notif
branch
from
b9f69b1 to
afbf704
Compare
karlenDimla
force-pushed
the
feature/karl/netp/expired-notif-dialog
branch
5 times, most recently
from
ecfae07 to
8e7c2ff
Compare
karlenDimla
commented
Dec 19, 2023
|
|
||
| import com.duckduckgo.navigation.api.GlobalActivityStarter.ActivityParams | ||
|
|
||
| sealed class SubscriptionScreens { |
There was a problem hiding this comment.
@marcosholgado let me know if you have any comments on this as well since included changes into some subscription stuff
karlenDimla
force-pushed
the
feature/karl/netp/expired-notif
branch
from
afbf704 to
3247153
Compare
aitorvs
reviewed
Dec 22, 2023
browser-api/src/main/java/com/duckduckgo/browser/api/ActivityLifecycleCallbacks.kt
Outdated
Show resolved
Hide resolved
| return state.asStateFlow() | ||
| } | ||
|
|
||
| override suspend fun authorize() { |
There was a problem hiding this comment.
I think we discussed this, we should return NetpAuthorizationStatus in this method for it not to entirely be a side effect
There was a problem hiding this comment.
Will not fix - will address in https://app.asana.com/0/0/1206170013724653/f
Comment on lines
81
to
85
| private fun attemptToAuthorize() { | ||
| viewModelScope.launch { | ||
| netpSubscriptionManager.authorize() | ||
| netpAuthManager.authorize() | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need this method at all? we can just call that as part of getState() flow in onStart() {}
There was a problem hiding this comment.
Will not fix - will address in https://app.asana.com/0/0/1206170013724653/f
...n/java/com/duckduckgo/networkprotection/subscription/ui/NetpVpnAccessRevokedDialogMonitor.kt
Show resolved
Hide resolved
...n/java/com/duckduckgo/networkprotection/subscription/ui/NetpVpnAccessRevokedDialogMonitor.kt
Show resolved
Hide resolved
...ions-impl/src/main/java/com/duckduckgo/subscriptions/impl/ui/SubscriptionsWebViewActivity.kt
Outdated
Show resolved
Hide resolved
aitorvs
approved these changes
Dec 22, 2023
karlenDimla
force-pushed
the
feature/karl/netp/expired-notif-dialog
branch
from
8e7c2ff to
3cf7c3f
Compare
karlenDimla
added a commit
that referenced
this pull request
Dec 22, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1206140936022690/f ### Description See attached task description ### Steps to test this PR https://app.asana.com/0/0/1206193043882713/f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206140936022690/f
Description
See attached task description
Steps to test this PR
https://app.asana.com/0/0/1206193043882713/f