Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pixel for voice search error #4029

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Remove pixel for voice search error #4029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/src/main/java/com/duckduckgo/app/global/api/PixelParamRemovalInterceptor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin.PixelPa
import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin.PixelParameter.APP_VERSION
import com.duckduckgo.common.utils.plugins.pixel.PixelParamRemovalPlugin.PixelParameter.ATB
import com.duckduckgo.di.scopes.AppScope
import com.duckduckgo.voice.impl.VoiceSearchPixelNames
import com.squareup.anvil.annotations.ContributesMultibinding
import javax.inject.Inject
import okhttp3.Interceptor
Expand Down Expand Up @@ -76,7 +75,6 @@ object PixelInterceptorPixelsRequiringDataCleaning : PixelParamRemovalPlugin {
return listOf(
AppPixelName.EMAIL_COPIED_TO_CLIPBOARD.pixelName to PixelParameter.removeAll(),
StatisticsPixelName.BROWSER_DAILY_ACTIVE_FEATURE_STATE.pixelName to PixelParameter.removeAll(),
VoiceSearchPixelNames.VOICE_SEARCH_ERROR.pixelName to PixelParameter.removeAll(),
)
}
}
4 changes: 0 additions & 4 deletions .../voice-search-impl/src/main/java/com/duckduckgo/voice/impl/VoiceSearchActivityLauncher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,6 @@ class RealVoiceSearchActivityLauncher @Inject constructor(
}
} else {
if (code == VOICE_SEARCH_ERROR) {
pixel.fire(
pixel = VoiceSearchPixelNames.VOICE_SEARCH_ERROR,
parameters = mapOf(KEY_PARAM_SOURCE to _source.paramValueName, "error" to data),
)
activity.window?.decorView?.rootView?.let {
val snackbar = Snackbar.make(it, activity.getString(string.voiceSearchError), Snackbar.LENGTH_LONG)
snackbar.view.translationY =
Expand Down
1 change: 0 additions & 1 deletion ...search/voice-search-impl/src/main/java/com/duckduckgo/voice/impl/VoiceSearchPixelNames.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@ enum class VoiceSearchPixelNames(override val pixelName: String) : Pixel.PixelNa
VOICE_SEARCH_PRIVACY_DIALOG_REJECTED("m_voice_search_privacy_dialog_rejected"),
VOICE_SEARCH_STARTED("m_voice_search_started"),
VOICE_SEARCH_DONE("m_voice_search_done"),
VOICE_SEARCH_ERROR("m_voice_search_error"),
}
1 change: 0 additions & 1 deletion ...earch-impl/src/test/java/com/duckduckgo/voice/impl/RealVoiceSearchActivityLauncherTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ class RealVoiceSearchActivityLauncherTest {
val lastKnownRequest = activityResultLauncherWrapper.lastKnownRequest as ActivityResultLauncherWrapper.Request.ResultFromVoiceSearch
lastKnownRequest.onResult(VoiceSearchActivity.VOICE_SEARCH_ERROR, "1")

verify(pixel).fire(VoiceSearchPixelNames.VOICE_SEARCH_ERROR, mapOf("source" to "browser", "error" to "1"))
assertNull(lastKnownEvent)
}

Expand Down
Loading