New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in connection quality #4039

Merged

aitorvs merged 1 commit into develop from fix/aitor/vpn/npe

Dec 22, 2023

Collaborator

aitorvs commented Dec 22, 2023 •

edited by karlenDimla

Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1206222242762043/f

Description

Fix NPE when aggregating connection quality

Steps to test this PR

Requirements:

test in emulator
mac computer connected to VPN

Test

filter logcat by Connection Quality
install from this branch and enable VPN
see connection quality measurements
increase latency by connecting your computer to an egress very far away
see connection quality measurements increasing and changing class


          Fix NPE in connection quality

daeb667

Collaborator Author

aitorvs commented Dec 22, 2023

Current dependencies on/for this PR:

develop
- PR Fix NPE in connection quality #4039 👈

This stack of pull requests is managed by Graphite.

aitorvs assigned karlenDimla

karlenDimla approved these changes

View reviewed changes

aitorvs merged commit 951d355 into develop

7 checks passed

aitorvs deleted the fix/aitor/vpn/npe branch

December 22, 2023 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet