Add export behavior to registered broadcast receivers #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @karlenDimla and the rest of your teammates on |
karlenDimla
force-pushed
the
feature/karl/target14/broadcastreceivers
branch
from
74eafaa to
402e249
Compare
karlenDimla
force-pushed
the
feature/karl/target14/broadcastreceivers
branch
from
402e249 to
45f5c2e
Compare
karlenDimla
commented
Jan 10, 2024
karlenDimla
force-pushed
the
feature/karl/target14/broadcastreceivers
branch
from
283eff9 to
f0a3dc4
Compare
aitorvs
approved these changes
Jan 12, 2024
.../java/com/duckduckgo/mobile/android/vpn/ui/notification/DeviceShieldNotificationScheduler.kt
Show resolved
Hide resolved
...ernal/src/main/java/com/duckduckgo/vpn/internal/feature/rules/ExceptionRulesDebugReceiver.kt
Outdated
Show resolved
Hide resolved
karlenDimla
force-pushed
the
feature/karl/target14/broadcastreceivers
branch
from
f2d7b74 to
6605e7f
Compare
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1206023003085403/f ### Description See attached task description ### Steps to test this PR Smoke test starting AppTP and Netp
karlenDimla
added a commit
that referenced
this pull request
Jan 16, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1206033184335184/f ### Description See attached task description ### Steps to test this PR Smoke test app, espcially the affected features mentioned in task description) verify that no `"java.lang.SecurityException: com.duckduckgo.mobile.android.debug: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts"` is logged
karlenDimla
added a commit
that referenced
this pull request
Jan 22, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1206033184335184/f ### Description See attached task description ### Steps to test this PR Smoke test app, espcially the affected features mentioned in task description) verify that no `"java.lang.SecurityException: com.duckduckgo.mobile.android.debug: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts"` is logged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206033184335184/f
Description
See attached task description
Steps to test this PR
Smoke test app, espcially the affected features mentioned in task description) verify that no
"java.lang.SecurityException: com.duckduckgo.mobile.android.debug: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts"is logged