Autofill: update dismiss logic to show snackbar #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @cmonfortep and the rest of your teammates on |
This was referenced Jul 31, 2024
cmonfortep
force-pushed
the
feature/cristian/autofill/default_on
branch
4 times, most recently
from
5e27e15 to
d6de23b
Compare
cmonfortep
force-pushed
the
feature/cristian/replace_disable_prompt_with_snackbar
branch
from
697b066 to
97cbe47
Compare
cmonfortep
force-pushed
the
feature/cristian/autofill/default_on
branch
from
d6de23b to
193bf7a
Compare
cmonfortep
force-pushed
the
feature/cristian/replace_disable_prompt_with_snackbar
branch
from
97cbe47 to
b855d08
Compare
cmonfortep
force-pushed
the
feature/cristian/autofill/default_on
branch
from
193bf7a to
9f278c7
Compare
cmonfortep
force-pushed
the
feature/cristian/replace_disable_prompt_with_snackbar
branch
from
b855d08 to
744ebe8
Compare
CDRussell
approved these changes
Aug 2, 2024
autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/pixel/AutofillPixelNames.kt
Show resolved
Hide resolved
cmonfortep
force-pushed
the
feature/cristian/autofill/default_on
branch
from
9f278c7 to
c4a818d
Compare
cmonfortep
force-pushed
the
feature/cristian/replace_disable_prompt_with_snackbar
branch
from
744ebe8 to
db49768
Compare
Task/Issue URL: https://app.asana.com/0/414730916066338/1207943705873936/f ### Description Aligns logic with other platforms around when don't ask users about disabling autofill: - if a password has been stored or user manually enabled autofill, then don't ask. ### Steps to test this PR _Feature 1_ - [ ] Fresh install - [ ] Perform any of the following actions (saving a password manually, enabling sync with another device with passwords, clicking on save on Save dialog when asked) - [ ] ensure onboarding dialog is completed - [ ] ensure dismissing twice the dialog prompt never asks user to disable autofill _Feature 2_ - [ ] Fresh install - [ ] Go into passwords and disable autofill, then enable it again - [ ] Go to a site an login - [ ] ensure save dialog shown but no onboarding - [ ] ensure dismissing twice the dialog prompt never asks user to disable autofill ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
cmonfortep
merged commit a9de8e8
into
feature/cristian/autofill/default_on
4 checks passed
cmonfortep
deleted the
feature/cristian/replace_disable_prompt_with_snackbar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1207895626594373/f
Description
Updates logic to show snackbar instead of Dialog after user dismisses twice our save dialog.
Steps to test this PR
Feature 1
autofill_logins_save_disable_snackbar_shown)autofill_logins_save_disable_snackbar_open_settings)m_autofill_logins_settings_disabledincludesdisable_promptas sourceUI changes