Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons cut off in Dialog single choice landscape #4846

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Aug 2, 2024

Task/Issue URL: https://app.asana.com/0/1205008441501016/1207953456660783/f

Description

Fix buttons cut off in Dialog single choice landscape. This was particularly noticeable in Duck Player, where the settings dialog had title and subtitle

Steps to test this PR

Feature 1

  • Smoke test single choice dialogs across the app

UI changes

dp_dialog
fire

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro marked this pull request as ready for review August 2, 2024 08:26
@malmstein malmstein self-assigned this Aug 2, 2024
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks @CrisBarreiro !

@CrisBarreiro CrisBarreiro merged commit 2499673 into develop Aug 5, 2024
7 checks passed
@CrisBarreiro CrisBarreiro deleted the fix/cris/dialog-single-choice-landscape branch August 5, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants