Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support experiments in Active plugins #4860

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Aug 5, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1207977093713099/f

Description

Add support for experiments in active plugins.
Add support to force active plugins enabled for internal builds.

Steps to test this PR

Ensure that DuDuckGo folder has been removed from Downloads folder to avoid returning user.

Control Group - mq - Play Flavour

  • Change Privacy Config URL to https://jsonblob.com/api/jsonBlob/1243573265112096768
  • Fresh install
  • Filter log to validate that mq variant has been assigned
  • Complete Onboarding and open New Tab
  • Verify legacy NTP is visible
  • Try a few times, ensure only legacy version is available

Variant Group - mr - Play Flavour

  • Change Privacy Config URL to https://jsonblob.com/api/jsonBlob/1270091613312245760
  • Fresh install
  • Filter log to validate that mr variant has been assigned
  • Complete Onboarding and open New Tab
  • Verify new NTP is visible
  • Try a few times, ensure only new version is available

Control Group - mq - Internal Flavour

  • Change Privacy Config URL to https://jsonblob.com/api/jsonBlob/1243573265112096768
  • Fresh install
  • Filter log to validate that mr variant has been assigned
  • Complete Onboarding and open New Tab
  • Verify new NTP is visible
  • Try a few times, ensure only new version is available

Copy link
Collaborator Author

aitorvs commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on Graphite Graphite

@malmstein malmstein self-assigned this Aug 5, 2024
@aitorvs aitorvs force-pushed the feature/aitor/ap-support-experiments branch from ac01d58 to a733697 Compare August 5, 2024 21:29
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Thanks @aitorvs!

@aitorvs aitorvs merged commit a017042 into develop Aug 6, 2024
6 checks passed
@aitorvs aitorvs deleted the feature/aitor/ap-support-experiments branch August 6, 2024 10:26
karlenDimla pushed a commit that referenced this pull request Aug 6, 2024
Task/Issue URL: https://app.asana.com/0/488551667048375/1207977093713099/f

### Description
Add support for experiments in active plugins.
Add support to force active plugins enabled for internal builds.

### Steps to test this PR

Ensure that DuDuckGo folder has been removed from Downloads folder to avoid returning user.

_Control Group - mq - Play Flavour_
- [ ] Change Privacy Config URL to `https://jsonblob.com/api/jsonBlob/1243573265112096768`
- [ ] Fresh install
- [ ] Filter log to validate that `mq` variant has been assigned
- [ ] Complete Onboarding and open New Tab
- [ ] Verify legacy NTP is visible
- [ ] Try a few times, ensure only legacy version is available

_Variant Group - mr - Play Flavour_
- [ ] Change Privacy Config URL to `https://jsonblob.com/api/jsonBlob/1270091613312245760`
- [ ] Fresh install
- [ ] Filter log to validate that `mr` variant has been assigned
- [ ] Complete Onboarding and open New Tab
- [ ] Verify new NTP is visible
- [ ] Try a few times, ensure only new version is available

_Control Group - mq - Internal Flavour_
- [x] Change Privacy Config URL to `https://jsonblob.com/api/jsonBlob/1243573265112096768 `
- [x] Fresh install
- [x] Filter log to validate that `mr` variant has been assigned
- [x] Complete Onboarding and open New Tab
- [x] Verify new NTP is visible
- [x] Try a few times, ensure only new version is available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants