-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support experiments in Active plugins #4860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aitorvs
force-pushed
the
feature/aitor/ap-support-experiments
branch
from
August 5, 2024 21:29
ac01d58
to
a733697
Compare
…kduckgo/Android into feature/aitor/ap-support-experiments
malmstein
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected. Thanks @aitorvs!
karlenDimla
pushed a commit
that referenced
this pull request
Aug 6, 2024
Task/Issue URL: https://app.asana.com/0/488551667048375/1207977093713099/f ### Description Add support for experiments in active plugins. Add support to force active plugins enabled for internal builds. ### Steps to test this PR Ensure that DuDuckGo folder has been removed from Downloads folder to avoid returning user. _Control Group - mq - Play Flavour_ - [ ] Change Privacy Config URL to `https://jsonblob.com/api/jsonBlob/1243573265112096768` - [ ] Fresh install - [ ] Filter log to validate that `mq` variant has been assigned - [ ] Complete Onboarding and open New Tab - [ ] Verify legacy NTP is visible - [ ] Try a few times, ensure only legacy version is available _Variant Group - mr - Play Flavour_ - [ ] Change Privacy Config URL to `https://jsonblob.com/api/jsonBlob/1270091613312245760` - [ ] Fresh install - [ ] Filter log to validate that `mr` variant has been assigned - [ ] Complete Onboarding and open New Tab - [ ] Verify new NTP is visible - [ ] Try a few times, ensure only new version is available _Control Group - mq - Internal Flavour_ - [x] Change Privacy Config URL to `https://jsonblob.com/api/jsonBlob/1243573265112096768 ` - [x] Fresh install - [x] Filter log to validate that `mr` variant has been assigned - [x] Complete Onboarding and open New Tab - [x] Verify new NTP is visible - [x] Try a few times, ensure only new version is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1207977093713099/f
Description
Add support for experiments in active plugins.
Add support to force active plugins enabled for internal builds.
Steps to test this PR
Ensure that DuDuckGo folder has been removed from Downloads folder to avoid returning user.
Control Group - mq - Play Flavour
https://jsonblob.com/api/jsonBlob/1243573265112096768
mq
variant has been assignedVariant Group - mr - Play Flavour
https://jsonblob.com/api/jsonBlob/1270091613312245760
mr
variant has been assignedControl Group - mq - Internal Flavour
https://jsonblob.com/api/jsonBlob/1243573265112096768
mr
variant has been assigned