Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks: New toolbar for sorting feature flag #5452

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Jan 9, 2025

Task/Issue URL: https://app.asana.com/0/1174433894299346/1209107275709085/f

Description

This PR adds the new toolbar for the Bookmarks screen under the feature flag
Note that the select sort icon doesn’t react to changes yet

Steps to test this PR

Toolbar functionality

  • Enable “bookmarksSorting” feature flag
  • Add a 4 bookmarks and open the bookmarks screen
  • Tap on the add folder icon
  • Verify Add folder screen opens
  • Tap on the overflow menu
  • Verify the new menu appear (Sort options available)
  • Go back and add another bookmark
  • Open bookmarks again
  • Verify Search icon appears
  • Tap on search icon
  • Run some queries verify filter still works

UI changes

New Old
Screenshot_20250110_135355 Screenshot_20250110_135419

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein marked this pull request as ready for review January 10, 2025 12:55
@malmstein malmstein requested a review from nalcalag as a code owner January 10, 2025 12:55
@anikiki anikiki self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants