Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Allow for Play Release to tag any ref #5465

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Jan 14, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1209148310024408/f

Description

This PR modifies the workflows to build APKs so that they take a ref as checkout parameter.

Test run https://github.com/duckduckgo/Android/actions/runs/12768825617/job/35590007000

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein marked this pull request as ready for review January 14, 2025 13:37
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malmstein
Copy link
Contributor Author

Thanks @cmonfortep !

@malmstein malmstein merged commit 468c41d into develop Jan 14, 2025
2 checks passed
@malmstein malmstein deleted the feature/david/01-14-gha_allow_for_play_release_to_tag_any_ref branch January 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants