Check late property is isInitialized #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitorvs
force-pushed
the
fix/aitor/launchVoiceSearch-crash
branch
from
12b4c61 to
7abcc09
Compare
karlenDimla
reviewed
Jan 21, 2025
| @@ -130,9 +130,10 @@ class RealVoiceSearchActivityLauncher @Inject constructor( | |||
| activity.window?.decorView?.rootView?.let { | |||
| blurRenderer.addBlur(it) | |||
| } | |||
| val stringSource = if (this::_source.isInitialized) _source.paramValueName else "" | |||
There was a problem hiding this comment.
I honestly think we should just not make this variable lateinit anymore. We should just make it Nullable.
There was a problem hiding this comment.
I don’t remember much why I set this to lateinit before, but looking now, nothing is enforcing the order of the method calls, so we shouldn’t use lateinit
There was a problem hiding this comment.
moved it to be a nullable var
aitorvs
force-pushed
the
fix/aitor/launchVoiceSearch-crash
branch
from
7abcc09 to
fe9b208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202552961248957/1209201227256746/f
Description
Ensure late property is init before using it
Steps to test this PR
NA, just code review